Skip to content

fix: Downgrade provider#531

Merged
disq merged 3 commits into
cloudquery:mainfrom
disq:fix/downgrade-provider
Mar 16, 2022
Merged

fix: Downgrade provider#531
disq merged 3 commits into
cloudquery:mainfrom
disq:fix/downgrade-provider

Conversation

@disq
Copy link
Copy Markdown
Member

@disq disq commented Mar 15, 2022

Closes #496.

This is extra bad, but given the way everything is set up this is what I ended up with.

@disq disq requested a review from roneli March 15, 2022 14:17
@github-actions github-actions Bot added the fix label Mar 15, 2022
Copy link
Copy Markdown
Contributor

@roneli roneli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay, I think we can avoid the extra upgrade, but fix me if I am incorrect in my assumption.

Comment thread pkg/ui/console/client.go
Copy link
Copy Markdown
Contributor

@roneli roneli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@disq disq merged commit 5e7c84a into cloudquery:main Mar 16, 2022
@disq disq deleted the fix/downgrade-provider branch March 16, 2022 10:25
TinLe pushed a commit to TinLe/cloudquery that referenced this pull request Mar 22, 2022
* upstream/main: (21 commits)
  feat: Ignore ignored diags unless -v is specified (cloudquery#545)
  chore: Sync form .github (cloudquery#527)
  chore: Clean up db version checks (cloudquery#542)
  fix: Validate Timescale Version (cloudquery#540)
  feat: Support timeouts in fetch (cloudquery#537)
  fix: Warn on providers with no resources requested (cloudquery#528)
  fix: Fixed local policy run (cloudquery#535)
  fix: Make Date a static value (cloudquery#534)
  fix: Downgrade provider (cloudquery#531)
  feat: Store cq_fetch_id in meta (cloudquery#523)
  fix: Foreign Keys in Snapshots (cloudquery#525)
  feat: Add file() func to config parser (cloudquery#522)
  feat: Drift: Add @getbool modifier (cloudquery#515)
  fix: Diag: Don't report errors we don't care about (cloudquery#521)
  fix: Handle if Path doesn't exist (cloudquery#518)
  fix: Keep binary reference consistent (cloudquery#516)
  fix: Validate DB connection with an explicit timeout, rather than the… (cloudquery#510)
  fix: Missing views in history mode (cloudquery#508)
  fix: Init command cleanup (cloudquery#502)
  fix: Upgrade/downgrade providers cleanup (cloudquery#498)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

provider downgrade doesn't work

2 participants