Skip to content

fix: Diag: Don't report ignorable errors#521

Merged
disq merged 4 commits into
cloudquery:mainfrom
disq:fix/classify-diags-before-sentry
Mar 8, 2022
Merged

fix: Diag: Don't report ignorable errors#521
disq merged 4 commits into
cloudquery:mainfrom
disq:fix/classify-diags-before-sentry

Conversation

@disq
Copy link
Copy Markdown
Member

@disq disq commented Mar 8, 2022

Also update SDK to use better sorting

@disq disq requested a review from roneli March 8, 2022 09:02
Also update SDK to use better sorting
@disq disq force-pushed the fix/classify-diags-before-sentry branch from d5fc5c2 to 73ca60f Compare March 8, 2022 09:03
@disq disq changed the title diag: Don't report errors we don't care about fix: Diag: Don't report errors we don't care about Mar 8, 2022
@github-actions github-actions Bot added the fix label Mar 8, 2022
Copy link
Copy Markdown
Contributor

@roneli roneli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@disq disq merged commit 8079070 into cloudquery:main Mar 8, 2022
@disq disq deleted the fix/classify-diags-before-sentry branch March 8, 2022 12:37
@disq disq changed the title fix: Diag: Don't report errors we don't care about fix: Diag: Don't report ignorable errors Mar 8, 2022
@github-actions github-actions Bot added fix and removed fix labels Mar 8, 2022
TinLe pushed a commit to TinLe/cloudquery that referenced this pull request Mar 22, 2022
* upstream/main: (21 commits)
  feat: Ignore ignored diags unless -v is specified (cloudquery#545)
  chore: Sync form .github (cloudquery#527)
  chore: Clean up db version checks (cloudquery#542)
  fix: Validate Timescale Version (cloudquery#540)
  feat: Support timeouts in fetch (cloudquery#537)
  fix: Warn on providers with no resources requested (cloudquery#528)
  fix: Fixed local policy run (cloudquery#535)
  fix: Make Date a static value (cloudquery#534)
  fix: Downgrade provider (cloudquery#531)
  feat: Store cq_fetch_id in meta (cloudquery#523)
  fix: Foreign Keys in Snapshots (cloudquery#525)
  feat: Add file() func to config parser (cloudquery#522)
  feat: Drift: Add @getbool modifier (cloudquery#515)
  fix: Diag: Don't report errors we don't care about (cloudquery#521)
  fix: Handle if Path doesn't exist (cloudquery#518)
  fix: Keep binary reference consistent (cloudquery#516)
  fix: Validate DB connection with an explicit timeout, rather than the… (cloudquery#510)
  fix: Missing views in history mode (cloudquery#508)
  fix: Init command cleanup (cloudquery#502)
  fix: Upgrade/downgrade providers cleanup (cloudquery#498)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants