fix: Init command cleanup#502
Merged
Merged
Conversation
Don't set "source" if default org, include drift config only with AWS
bbernays
reviewed
Feb 23, 2022
bbernays
reviewed
Feb 23, 2022
|
|
||
| // ParseProviderNameWithVersion parses the given string as "repository/provider@version" or "provider@version" (or @version omitted, defaulting to "latest") | ||
| func ParseProviderNameWithVersion(nameWithVersion string) (string, string, string, error) { | ||
| versionParts := strings.Split(nameWithVersion, "@") |
Collaborator
There was a problem hiding this comment.
I think we should be documenting what characters can be in a provider name, because this assumes that there is never an @ in a provider name
Member
Author
There was a problem hiding this comment.
Yes but a repo with @ in the name is not possible with github anyway...
Collaborator
There was a problem hiding this comment.
For my own knowledge, do providers have to be on Github? I know that policies can be in many different locations
Member
Author
There was a problem hiding this comment.
Looks like they can be anywhere as long as they're indexed in our Firestore (registry/hub.go)
yevgenypats
approved these changes
Feb 28, 2022
TinLe
pushed a commit
to TinLe/cloudquery
that referenced
this pull request
Mar 22, 2022
* upstream/main: (21 commits) feat: Ignore ignored diags unless -v is specified (cloudquery#545) chore: Sync form .github (cloudquery#527) chore: Clean up db version checks (cloudquery#542) fix: Validate Timescale Version (cloudquery#540) feat: Support timeouts in fetch (cloudquery#537) fix: Warn on providers with no resources requested (cloudquery#528) fix: Fixed local policy run (cloudquery#535) fix: Make Date a static value (cloudquery#534) fix: Downgrade provider (cloudquery#531) feat: Store cq_fetch_id in meta (cloudquery#523) fix: Foreign Keys in Snapshots (cloudquery#525) feat: Add file() func to config parser (cloudquery#522) feat: Drift: Add @getbool modifier (cloudquery#515) fix: Diag: Don't report errors we don't care about (cloudquery#521) fix: Handle if Path doesn't exist (cloudquery#518) fix: Keep binary reference consistent (cloudquery#516) fix: Validate DB connection with an explicit timeout, rather than the… (cloudquery#510) fix: Missing views in history mode (cloudquery#508) fix: Init command cleanup (cloudquery#502) fix: Upgrade/downgrade providers cleanup (cloudquery#498) ...
This was referenced May 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sourceif default orgcloudquery init provider@versioncloudquery init <provider>ifconfig.hclloading fails withfs.ErrNotExist