Skip to content

Dockerfile4.9#1435

Closed
pdion891 wants to merge 10 commits into
apache:masterfrom
pdion891:dockerfile4.9
Closed

Dockerfile4.9#1435
pdion891 wants to merge 10 commits into
apache:masterfrom
pdion891:dockerfile4.9

Conversation

@pdion891
Copy link
Copy Markdown
Contributor

  • Fixed docker build for simulator, marvin and management-server.
  • Fixed change of release script to update dockerfiles.
  • I will update Jenkins builds once merged.

@yadvr
Copy link
Copy Markdown
Member

yadvr commented May 2, 2016

@pdion891 rebase against latest master and squash commits into a single commit, thanks

LGTM

tag:easypr

Comment thread tools/docker/Dockerfile.centos6 Outdated
LABEL Vendor="Apache.org" License="ApacheV2" Version="4.9.0-SNAPSHOT"

ENV PKG_URL=http://jenkins.buildacloud.org/job/package-rhel63-master/lastSuccessfulBuild/artifact/dist/rpmbuild/RPMS/x86_64
ENV PKG_URL=http://74.121.245.247/job/package-master-rhel63/lastSuccessfulBuild/artifact/dist/rpmbuild/RPMS/x86_64
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rhtyd, @swill I know this is wrong, but the new URL is not live yet: builds.cloudstack.org so either we merge this and I'll update it at some point or we just cancel this PR until the URL go live ?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with either ways, is the jenkins server on this IP public and can we have accounts on it?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rhtyd I've create you an account on the Jenkins server. not a lot of jobs are there yet.
Lets continue the discussion on slack...

@bvbharatk
Copy link
Copy Markdown
Contributor

ACS CI BVT Run

Sumarry:
Build Number 146
Hypervisor xenserver
NetworkType Advanced
Passed=68
Failed=5
Skipped=3

Link to logs Folder (search by build_no): https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0

Failed tests:

  • test_vpc_vpn.py
    • ContextSuite context=TestRVPCSite2SiteVpn>:setup Failing since 11 runs
    • ContextSuite context=TestVpcRemoteAccessVpn>:setup Failing since 11 runs
    • ContextSuite context=TestVpcSite2SiteVpn>:setup Failing since 11 runs
  • test_volumes.py
    • test_06_download_detached_volume Failed
  • test_vm_life_cycle.py
    • test_10_attachAndDetach_iso Failed

Skipped tests:
test_vm_nic_adapter_vmxnet3
test_static_role_account_acls
test_deploy_vgpu_enabled_vm

Passed test suits:
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_over_provisioning.py
test_global_settings.py
test_scale_vm.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_routers.py
test_reset_vm_on_reboot.py
test_snapshots.py
test_deploy_vms_with_varied_deploymentplanners.py
test_login.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_disk_offerings.py

@pdion891
Copy link
Copy Markdown
Contributor Author

pdion891 commented Jun 9, 2016

@swill, @Runseb does one of you could LGTM or comment thanks,

@sebgoa
Copy link
Copy Markdown
Member

sebgoa commented Jun 9, 2016

LGTM

I still think we need to put the db in another container, and start the whole thing with compose.
Also we need to make the image smaller, maybe using Debian as base would be smaller than then full ubuntu:14.04

@pdion891
Copy link
Copy Markdown
Contributor Author

pdion891 commented Jun 9, 2016

@Runseb I agree, images must be smaller. for the simulator, it's kind of usefull to have everything in it but it's not container best practice for sure. other images, we could probably use alpine linux, but still need to figure out how to run cloudstack as a single .war file.

@pdion891
Copy link
Copy Markdown
Contributor Author

pdion891 commented Dec 1, 2016

@resmo I've updated the PR. I've tested the simulator and marvin.

@pdion891
Copy link
Copy Markdown
Contributor Author

pdion891 commented Dec 1, 2016

Hi @jburwell, do you think we can merge this in master or you are in a code freeze for 4.10.0.0 ?

Thanks,

@jburwell
Copy link
Copy Markdown
Contributor

jburwell commented Dec 1, 2016

@PaulAngus @rhtyd what are your thoughts on automating the testing of the Docker container?

@jburwell
Copy link
Copy Markdown
Contributor

jburwell commented Dec 1, 2016

@pdion891 I would like to merge this PR and #1769 before we hard freeze 4.9.1.0 (which is ASAP right now). In order to get this PR pulled through, could you please address the following issues:

  • Open a JIRA ticket for this issue and reference it in the commit message
  • Squash commits
  • Address Jenkins failures

@yadvr
Copy link
Copy Markdown
Member

yadvr commented Dec 1, 2016

@jburwell good to have this, not sure how many people maybe using container/docker based mgmt servers?

@jburwell
Copy link
Copy Markdown
Contributor

jburwell commented Dec 1, 2016

@rhtyd agreed. I apologize for being unclear -- I would like to get this PR into 4.9.1.0, but it is not a release blocker.

@resmo
Copy link
Copy Markdown
Member

resmo commented Dec 1, 2016

I used it for development and testing.

@pdion891
Copy link
Copy Markdown
Contributor Author

pdion891 commented Dec 1, 2016

I've retested the management server, it work with Jenkins as the build is back online.

@jburwell, do you know if there is a way to squash a commit within the same PR ?

@jburwell
Copy link
Copy Markdown
Contributor

jburwell commented Dec 1, 2016

@pdion891 this blog is good description of squash process.

pdion891 added a commit to pdion891/cloudstack that referenced this pull request Dec 2, 2016
@pdion891 pdion891 mentioned this pull request Dec 2, 2016
pdion891 added a commit to pdion891/cloudstack that referenced this pull request Dec 2, 2016
pdion891 added a commit to pdion891/cloudstack that referenced this pull request Dec 2, 2016
@pdion891
Copy link
Copy Markdown
Contributor Author

pdion891 commented Dec 3, 2016

This PR is not valid anymore replaced by Squashed: #1815

@pdion891 pdion891 closed this Dec 3, 2016
asfgit pushed a commit that referenced this pull request Dec 9, 2016
Fix docker image build for cloudstack-managementCLOUDSTACK-9651

Fix Docker images build for 4.10.0.0:
- simulator
- marvin
- management_centos6

Squashed version of #1435.

* pr/1815:
  CLOUDSTACK-9651; fix docker image build for cloudstack-management, simulator and marvin for 4.10.0.0 close #1435

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants