Dockerfile4.9#1435
Conversation
pdion891
commented
Mar 10, 2016
- Fixed docker build for simulator, marvin and management-server.
- Fixed change of release script to update dockerfiles.
- I will update Jenkins builds once merged.
|
@pdion891 rebase against latest master and squash commits into a single commit, thanks LGTM tag:easypr |
…into dockerfile4.9
| LABEL Vendor="Apache.org" License="ApacheV2" Version="4.9.0-SNAPSHOT" | ||
|
|
||
| ENV PKG_URL=http://jenkins.buildacloud.org/job/package-rhel63-master/lastSuccessfulBuild/artifact/dist/rpmbuild/RPMS/x86_64 | ||
| ENV PKG_URL=http://74.121.245.247/job/package-master-rhel63/lastSuccessfulBuild/artifact/dist/rpmbuild/RPMS/x86_64 |
There was a problem hiding this comment.
@rhtyd, @swill I know this is wrong, but the new URL is not live yet: builds.cloudstack.org so either we merge this and I'll update it at some point or we just cancel this PR until the URL go live ?
There was a problem hiding this comment.
I'm fine with either ways, is the jenkins server on this IP public and can we have accounts on it?
There was a problem hiding this comment.
@rhtyd I've create you an account on the Jenkins server. not a lot of jobs are there yet.
Lets continue the discussion on slack...
ACS CI BVT RunSumarry: Link to logs Folder (search by build_no): https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0 Failed tests:
Skipped tests: Passed test suits: |
|
LGTM I still think we need to put the db in another container, and start the whole thing with compose. |
|
@Runseb I agree, images must be smaller. for the simulator, it's kind of usefull to have everything in it but it's not container best practice for sure. other images, we could probably use alpine linux, but still need to figure out how to run cloudstack as a single .war file. |
101e22c to
ba3c507
Compare
|
@resmo I've updated the PR. I've tested the simulator and marvin. |
|
Hi @jburwell, do you think we can merge this in master or you are in a code freeze for 4.10.0.0 ? Thanks, |
|
@PaulAngus @rhtyd what are your thoughts on automating the testing of the Docker container? |
|
@pdion891 I would like to merge this PR and #1769 before we hard freeze 4.9.1.0 (which is ASAP right now). In order to get this PR pulled through, could you please address the following issues:
|
|
@jburwell good to have this, not sure how many people maybe using container/docker based mgmt servers? |
|
@rhtyd agreed. I apologize for being unclear -- I would like to get this PR into 4.9.1.0, but it is not a release blocker. |
|
I used it for development and testing. |
|
I've retested the management server, it work with Jenkins as the build is back online. @jburwell, do you know if there is a way to squash a commit within the same PR ? |
…mulator and marvin for 4.10.0.0 close apache#1435
…mulator and marvin for 4.10.0.0 close apache#1435, close apache#1814
…mulator and marvin for 4.10.0.0 close apache#1435
|
This PR is not valid anymore replaced by Squashed: #1815 |
Fix docker image build for cloudstack-managementCLOUDSTACK-9651 Fix Docker images build for 4.10.0.0: - simulator - marvin - management_centos6 Squashed version of #1435. * pr/1815: CLOUDSTACK-9651; fix docker image build for cloudstack-management, simulator and marvin for 4.10.0.0 close #1435 Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>