tools: fix Dockerfile#1769
Closed
resmo wants to merge 1 commit into
Closed
Conversation
Member
|
LGTM. @pdion891 would you like to review? |
Contributor
|
Could you look if it conflict with #1435 ? Because I made a pull request to automatically increment version in docker file when changing release of master via |
Contributor
|
Changes look good to me, but waiting for @pdion891 to tell us more :) |
Member
Author
Contributor
Contributor
Member
Author
Contributor
|
ok, I'll update the PR and merge it I think the PR go all required LGTM. I'll confirmed with John, in case he is in a code freeze period. |
Closed
Member
Contributor
|
Hi @resmo, I've made some changes on the Docker file so it might not be possible to merge this PR in the current state. Thanks! |
Member
Author
|
ok, np closing for now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build a docker image did not work anymore for various reasons. This is how I fixed it