Fix docker image build for cloudstack-management#1815
Conversation
…mulator and marvin for 4.10.0.0 close apache#1435
|
@pdion891 thanks, how may I test this? |
|
LGTM but really the database should be outside the mgt server container and we should not be using supervisord. |
|
@sebgoa , I agree with you, it's just the easiest way to have a cloudstack with simulator preconfigured ready to work. We should not use package for the image management also. I've made basic tests while doing the PR has I got images that were working. But I haven't test using the management server managing real hypervisors. |
|
IMHO this is not meant for production, but quick fire up a docker having the current state of development. The image will be huge but for non-devs (like me) a easy way to get a running devel cloudstack in minutes. LGTM |
|
Thanks, @pdion891 are you satisfied with the changes or you want to improve them. I'm LGTM on this, can merge on your conclusion. Thanks. |
|
Thanks @rhtyd, let merge it so we have the simulator back online on docker hub and let's improve our Docker images... @jburwell, @rhtyd , do I merge it or you do it? I'm just wondering since we are close from a release. Thanks |
Fix docker image build for cloudstack-managementCLOUDSTACK-9651 Fix Docker images build for 4.10.0.0: - simulator - marvin - management_centos6 Squashed version of #1435. * pr/1815: CLOUDSTACK-9651; fix docker image build for cloudstack-management, simulator and marvin for 4.10.0.0 close #1435 Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
|
Thanks @rhtyd ! |
CLOUDSTACK-9651
Fix Docker images build for 4.10.0.0:
Squashed version of #1435.