Skip to content

fix(compiler-cli): do not treat declaration files as compilation roots in preprocessor - #71428

Merged
crisbeto merged 1 commit into
angular:mainfrom
crisbeto:more-ngp-memory
Oct 19, 2026
Merged

crisbeto merged 1 commit into
angular:mainfrom
crisbeto:more-ngp-memory

Conversation

@crisbeto

Copy link
Copy Markdown
Member

Declaration files listed in a tsconfig's files (every transitive dependency, in Bazel-style builds) were analyzed as roots, processed and streamed to the host, which then emitted .d.ng.ts/.d.ng.ts.map/.d.ngtypecheck.ts next to each of them. This can end up consuming a lot of memory and potentially exhaust some targets.

…s in preprocessor

Declaration files listed in a tsconfig's `files` (every transitive dependency, in Bazel-style builds) were analyzed as roots, processed and streamed to the host, which then emitted `.d.ng.ts`/`.d.ng.ts.map`/`.d.ngtypecheck.ts` next to each of them. This can end up consuming a lot of memory and potentially exhaust some targets.
@crisbeto crisbeto added action: review The PR is still awaiting reviews from at least one requested reviewer target: minor This PR is targeted for the next minor release labels Oct 19, 2026
@angular-robot angular-robot Bot added the area: compiler Issues related to `ngc`, Angular's template compiler label Oct 19, 2026
@ngbot ngbot Bot added this to the Backlog milestone Oct 19, 2026
@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Oct 19, 2026
@crisbeto
crisbeto merged commit d7be93c into angular:main Oct 19, 2026
27 of 29 checks passed
@crisbeto

Copy link
Copy Markdown
Member Author

This PR was merged into the repository. The changes were merged into the following branches:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker area: compiler Issues related to `ngc`, Angular's template compiler target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants