Repository navigation
fix(compiler-cli): emit NG1003 and NG1002 for bare @Pipe and invalid @NgModule calls - #71439
Merged
crisbeto merged 1 commit intoOct 20, 2026
Merged
Conversation
mattrbeck
force-pushed
the
fix/ngp-bare-pipe-ngmodule-diagnostics
branch
from
October 19, 2026 22:57
fd58204 to
a97a04e
Compare
mattrbeck
marked this pull request as ready for review
October 20, 2026 01:04
crisbeto
approved these changes
Oct 20, 2026
Member
|
This PR was merged into the repository. The changes were merged into the following branches:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #71427.
Checks
is_angular_decorator_namedbefore requiringExpression::CallExpressioninpipe::parse_decoratorandngmodule::parse_decorator, returning default metadata on malformed calls soparse_classretains the class and surfaces theNG1003andNG1002diagnostics produced byclass_decorator_argument_issue.Without this change,
test_directive_metadata_shape_diagnosticsfails on the three new cases (/project/pipe-bare.ts,/project/ng-module-bare.ts, and/project/ng-module-arity.ts) becausepipe::parse_decoratorandngmodule::parse_decoratorreturnNone, leavingng_decorator_spansempty soparse_classreturnsNoneand emits[](no diagnostics) instead ofNG1003(@Pipe must be called) andNG1002(Incorrect number of arguments to @NgModule decorator).