Repository navigation
Conversation
…g entrypoints Filter resolved tsconfig files with is_compilation_root before calling fs.canonicalize during entrypoint discovery and re-resolution in ng-analyze. Previously, every .d.ts file in the tsconfig root files list incurred an unnecessary filesystem canonicalize call before being discarded.
mattrbeck
force-pushed
the
perf/ngp-filter-dts-before-canonicalize
branch
from
October 19, 2026 22:57
ed40df9 to
9482e11
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #71428.
Filters
resolved_config.fileswithis_compilation_rootbefore callingfs.canonicalizeduring entrypoint discovery and re-resolution inng-analyze, avoiding unnecessaryrealpathcalls on.d.tsentries intsconfig.jsonfileslists.Without this change,
test_dts_root_files_are_not_canonicalized_during_entrypoint_discoverypanics withunexpected canonicalize of /project/unused.d.tsbecauseunused.d.tsis passed toPhysicalFs::canonicalizebefore being filtered out byis_compilation_root.