docs(animations): remove incorrect information regarding animateChild#44216
Closed
dario-piotrowicz wants to merge 1 commit into
Closed
docs(animations): remove incorrect information regarding animateChild#44216dario-piotrowicz wants to merge 1 commit into
dario-piotrowicz wants to merge 1 commit into
Conversation
1529fcb to
01d10d8
Compare
15 tasks
Contributor
Author
|
Note: this PR is related to #44243, the result of that PR will likely change what this PR should change in the docs |
01d10d8 to
f7107f9
Compare
Remove incorrect information present in the angular.io animations documentation stating that animateChild does not work with route transition animations as that turned out not to be true This PR effectively reverts the changes make in PR: angular#44014 For more context see issue angular#30477
f7107f9 to
d5bd538
Compare
jessicajaniuk
approved these changes
Nov 24, 2021
Contributor
jessicajaniuk
left a comment
There was a problem hiding this comment.
LGTM 🍪
Thanks for fixing this!
Contributor
|
This PR was merged into the repository by commit 7b0e9b0. |
jessicajaniuk
pushed a commit
that referenced
this pull request
Nov 24, 2021
…#44216) Remove incorrect information present in the angular.io animations documentation stating that animateChild does not work with route transition animations as that turned out not to be true This PR effectively reverts the changes make in PR: #44014 For more context see issue #30477 PR Close #44216
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove incorrect information present in the angular.io animations documentation
stating that animateChild does not work with route transition animations
as that turned out not to be true
This PR effectively reverts the changes make in PR: #44014
For more context see issue #30477
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
Some information in the angular.io animations documentation turned out to be inaccurate, the info tells the user that the animateChild function doesn't work with route transition animation which is not actually the case
(as I showed in stackblitz the the issue's thread)
What is the new behavior?
The information has been amended and the workarounds I've found while looking into the issues are also presented to the user
Does this PR introduce a breaking change?
Other information