Skip to content

docs(animations): remove incorrect information regarding animateChild #44216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dario-piotrowicz wants to merge 1 commit into from
Closed

docs(animations): remove incorrect information regarding animateChild #44216

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions aio/content/guide/animations.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,7 +289,7 @@ What it does

<tr>
<td><code>query()</code></td>
<td>Finds one or more inner HTML elements within the current element. </td>
<td>Finds one or more inner HTML elements within the current element.</td>
</tr>

<tr>
Expand All @@ -314,7 +314,7 @@ What it does

<tr>
<td><code>animateChild()</code></td>
<td>Allows animations on child components to be run within the same timeframe as the parent. <strong>Note:</strong> Please see GitHub Issue <a href="https://github.com/angular/angular/issues/30477">#30477</a> before attempting to use <code>animateChild()</code> together with route transition animations.</td>
Comment thread
dario-piotrowicz marked this conversation as resolved.
Outdated
<td>Allows animations on child components to be run within the same timeframe as the parent.</td>
</tr>

</table>
Expand Down
12 changes: 0 additions & 12 deletions aio/content/guide/route-animations.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,12 +75,6 @@ Animations can be defined directly inside your components. For this example you

The following code snippet defines a reusable animation named `slideInAnimation`.

<div class="alert is-important">

**Note:** `animateChild()` does not currently work with route transition animations. Please see GitHub Issue <a href="https://github.com/angular/angular/issues/30477">#30477</a> for more information.

</div>

<code-example path="animations/src/app/animations.ts" header="src/app/animations.ts" region="route-animations" language="typescript"></code-example>

The animation definition performs the following tasks:
Expand Down Expand Up @@ -114,12 +108,6 @@ Use the `query()` method to find and animate elements within the current host co

Assume that you are routing from the *Home => About*.

<div class="alert is-important">
Comment thread
dario-piotrowicz marked this conversation as resolved.
Outdated

**Note:** `animateChild()` does not currently work with route transition animations. Please see GitHub Issue <a href="https://github.com/angular/angular/issues/30477">#30477</a> for more information.

</div>

<code-example path="animations/src/app/animations.ts" header="src/app/animations.ts (excerpt)" region="query" language="typescript"></code-example>

The animation code does the following after styling the views:
Expand Down
4 changes: 0 additions & 4 deletions packages/animations/src/animation_metadata.ts
100755 → 100644
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1114,10 +1114,6 @@ export function animation(
* with animations that are assigned using the Angular animation library. CSS keyframes
* and transitions are not handled by this API.
*
* `animateChild()` does not currently work with route transition animations. Please see
* GitHub Issue {@link https://github.com/angular/angular/issues/30477 #30477} for more
* information.
*
* @publicApi
*/
export function animateChild(options: AnimateChildOptions|null = null):
Expand Down