docs(animations): update developers on state of package#44014
docs(animations): update developers on state of package#44014michaelurban wants to merge 2 commits into
Conversation
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
petebacondarwin
left a comment
There was a problem hiding this comment.
Thanks for helping to clarify things in this guide @michaelurban.
I made some suggestions that should enable us to land this change.
There was a problem hiding this comment.
Can we drop this top level alert, since this is more of a comment about the team than a helpful guide to people reading the guide.
Notify developers that @angular/animations package has been "significantly de-prioritized" `animateChild` documentation now references angular#30477 References angular#30477# Please enter the commit message for your changes. Lines starting
f448bee to
1248eeb
Compare
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
petebacondarwin
left a comment
There was a problem hiding this comment.
Reviewed-for: global-docs-approvers
|
@googlebot I consent. |
|
Caretaker: this is a docs only change, so there is no need for a presubmit. |
|
This PR was merged into the repository by commit baab456. |
Remove incorrect information present in the angular.io animations documentation stating that animateChild does not work with route transition animations as that turned out not to be true This PR effectively reverts the changes make in PR: angular#44014 For more context see issue angular#30477
…#44216) Remove incorrect information present in the angular.io animations documentation stating that animateChild does not work with route transition animations as that turned out not to be true This PR effectively reverts the changes make in PR: #44014 For more context see issue #30477 PR Close #44216
…#44216) Remove incorrect information present in the angular.io animations documentation stating that animateChild does not work with route transition animations as that turned out not to be true This PR effectively reverts the changes make in PR: #44014 For more context see issue #30477 PR Close #44216
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Notify developers that @angular/animations package has been "significantly de-prioritized"
animateChilddocumentation now references #30477References #30477
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: 30477
What is the new behavior?
Does this PR introduce a breaking change?
Other information