ci: re-enable size tracking in integration tests#23515
Conversation
| https://circleci.com/gh/angular/angular/edit#advanced-settings) | ||
|
|
||
| We use this as a symmetric AES encryption key to encrypt tokens like | ||
| a GitHub token that enables publishing snapshots. |
There was a problem hiding this comment.
OOC, why not have the GitHub- or Firebase tokens directly as secret vars on CircleCI, instead of KEY?
There was a problem hiding this comment.
I think this is so that we can update these tokens in the future, or add new ones, using only version control operations. Having one decryption key makes this as similar as possible to Travis (where they hold a private key)
| name: Set Angular build environment variables | ||
| command: | | ||
| echo "export PROJECT_ROOT=$(pwd)" >> $BASH_ENV | ||
| # CircleCI does not expose the commit range variable but we can easily |
| # CircleCI does not expose the commit range variable but we can easily | ||
| # get what we want from the compare URL which looks like | ||
| # https://github.com/angular/angular/compare/4361560...f0d1403 | ||
| echo "export COMMIT_RANGE=${CIRCLE_COMPARE_URL##*/}" >> $BASH_ENV |
There was a problem hiding this comment.
$CIRCLE_COMPARE_URL seems to be empty btw 😁
There was a problem hiding this comment.
yeah this part is totally broken...
|
Hi @alexeagle! This PR has merge conflicts due to recent upstream merges. |
See angular#22810, angular#23376 and angular#23515 for more context. Fixes angular#23376 Closes angular#23515
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Fixes #23376