test: integration tests now against bazel built packages by alexeagle · Pull Request #22810 · angular/angular

alexeagle · 2018-03-15T22:40:11Z

No description provided.

mary-poppins · 2018-03-15T22:48:01Z

You can preview 5c1e98e at https://pr22810-5c1e98e.ngbuilds.io/.

mary-poppins · 2018-03-19T16:27:01Z

You can preview a9833cd at https://pr22810-a9833cd.ngbuilds.io/.

mary-poppins · 2018-03-19T16:50:27Z

You can preview 2518fab at https://pr22810-2518fab.ngbuilds.io/.

ngbot · 2018-03-20T20:58:14Z

Hi @alexeagle! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

ngbot · 2018-03-20T20:58:39Z

Hi @alexeagle! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

ngbot · 2018-03-20T20:59:14Z

Hi @alexeagle! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

mary-poppins · 2018-03-21T00:29:42Z

You can preview 6f20ede at https://pr22810-6f20ede.ngbuilds.io/.

alexeagle · 2018-03-21T20:27:03Z

Handing this off to @IgorMinar who has already been updating the integration tests for changes in Angular 6

mary-poppins · 2018-03-28T23:16:49Z

You can preview 9586c39 at https://pr22810-9586c39.ngbuilds.io/.

googlebot · 2018-03-29T01:20:46Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

mary-poppins · 2018-03-29T01:28:47Z

You can preview 8bb8772 at https://pr22810-8bb8772.ngbuilds.io/.

mary-poppins · 2018-03-29T01:49:08Z

You can preview f3617c5 at https://pr22810-f3617c5.ngbuilds.io/.

mary-poppins · 2018-03-29T02:20:20Z

You can preview 7581edf at https://pr22810-7581edf.ngbuilds.io/.

mary-poppins · 2018-03-29T02:39:43Z

You can preview 1c939f8 at https://pr22810-1c939f8.ngbuilds.io/.

ngbot · 2018-03-30T22:04:56Z

Hi @alexeagle! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

mary-poppins · 2018-04-13T19:04:00Z

You can preview 7379c23 at https://pr22810-7379c23.ngbuilds.io/.

mary-poppins · 2018-04-13T19:11:25Z

You can preview 411f359 at https://pr22810-411f359.ngbuilds.io/.

gkalpak · 2018-03-30T17:27:26Z

Is this still needed now that ./integration/run_tests.sh is not run?

yes, internally that integration test has package.json with "@angular/platform-server": "file:../../../dist/packages-dist/platform-server", so it's really using the same formula as the other integration/* tests and should be moved, will do that

Now it lives in our standard location for tests against npm packages

The only remaining test can run in the first e2e travis shard. This also removes the last thing needing bazel available on Travis.

googlebot · 2018-04-13T22:09:29Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

mary-poppins · 2018-04-13T22:10:07Z

You can preview 857d595 at https://pr22810-857d595.ngbuilds.io/.

IgorMinar · 2018-04-13T22:46:56Z

  (
    cd $testDir
    rm -rf dist
+    pwd


echo "" echo "" echo " ======= running integration tests: `pwd`"

this was right above in the bigger ### fences

IgorMinar · 2018-04-13T23:01:44Z

-      rm -rf node_modules
+      #if $CI; then
+      #  trackPayloadSize "$testDir" "dist/*.js" true false "${basedir}/integration/_payload-limits.json"
+      #fi


so we are disabling the size tracking for cli hello world?
is this because we don't have credentials setup yet?
can you add a todo and explanation?

filed #23376

PR Close #22810

Now it lives in our standard location for tests against npm packages PR Close #22810

The only remaining test can run in the first e2e travis shard. This also removes the last thing needing bazel available on Travis. PR Close #22810

See angular#22810, angular#23376 and angular#23515 for more context. Fixes angular#23376 Closes angular#23515

See #22810, #23376 and #23515 for more context. Fixes #23376 Closes #23515 PR Close #26869

angular-automatic-lock-bot · 2019-09-13T13:21:24Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

googlebot added the cla: yes label Mar 15, 2018

alexeagle force-pushed the apf_v6 branch from 5c1e98e to a9833cd Compare March 19, 2018 16:15

alexeagle added the target: major This PR is targeted for the next major release label Mar 19, 2018

alexeagle force-pushed the apf_v6 branch from a9833cd to 2518fab Compare March 19, 2018 16:37

alexeagle force-pushed the apf_v6 branch from 2518fab to 341dd72 Compare March 20, 2018 06:27

alexeagle force-pushed the apf_v6 branch from 341dd72 to 6f20ede Compare March 21, 2018 00:10

matsko added the area: build & ci Related the build and CI infrastructure of the project label Mar 21, 2018

alexeagle assigned IgorMinar Mar 21, 2018

IgorMinar force-pushed the apf_v6 branch from 6f20ede to 9586c39 Compare March 28, 2018 23:06

googlebot added cla: no and removed cla: yes labels Mar 29, 2018

alexeagle force-pushed the apf_v6 branch 3 times, most recently from e77c76f to 67b3dc3 Compare March 30, 2018 20:24

manughub added this to the v6.0 milestone Apr 3, 2018

googlebot added cla: no and removed cla: yes labels Apr 13, 2018

ci: define common env vars in CircleCI job

411f359

gkalpak force-pushed the apf_v6 branch from 7379c23 to 411f359 Compare April 13, 2018 19:01

gkalpak reviewed Apr 13, 2018

View reviewed changes

alexeagle added 2 commits April 13, 2018 14:58

test: move platform-server integration test

6a67e4b

Now it lives in our standard location for tests against npm packages

ci: remove travis e2e_2 job

857d595

The only remaining test can run in the first e2e travis shard. This also removes the last thing needing bazel available on Travis.

alexeagle added cla: yes and removed cla: no labels Apr 13, 2018

IgorMinar approved these changes Apr 13, 2018

View reviewed changes

alexeagle mentioned this pull request Apr 13, 2018

re-enable size tracking in integration tests #23376

Closed

alexeagle added the action: merge The PR is ready for merge by the caretaker label Apr 13, 2018

IgorMinar closed this in 328b48b Apr 13, 2018

IgorMinar pushed a commit that referenced this pull request Apr 13, 2018

ci: define common env vars in CircleCI job (#22810)

29b838c

PR Close #22810

IgorMinar pushed a commit that referenced this pull request Apr 13, 2018

test: move platform-server integration test (#22810)

102ed3b

Now it lives in our standard location for tests against npm packages PR Close #22810

IgorMinar pushed a commit that referenced this pull request Apr 13, 2018

ci: remove travis e2e_2 job (#22810)

7e581da

The only remaining test can run in the first e2e travis shard. This also removes the last thing needing bazel available on Travis. PR Close #22810

gkalpak added a commit to gkalpak/angular that referenced this pull request Oct 31, 2018

ci: fix and re-enable payload size checks for integration tests

e563aab

See angular#22810, angular#23376 and angular#23515 for more context. Fixes angular#23376 Closes angular#23515

kara pushed a commit that referenced this pull request Nov 2, 2018

ci: fix and re-enable payload size checks for integration tests (#26869)

c40677a

See #22810, #23376 and #23515 for more context. Fixes #23376 Closes #23515 PR Close #26869

kara pushed a commit that referenced this pull request Nov 2, 2018

ci: fix and re-enable payload size checks for integration tests (#26869)

d96ba0f

See #22810, #23376 and #23515 for more context. Fixes #23376 Closes #23515 PR Close #26869

angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 13, 2019

Uh oh!

Conversation

alexeagle commented Mar 15, 2018

Uh oh!

mary-poppins commented Mar 15, 2018

Uh oh!

mary-poppins commented Mar 19, 2018

Uh oh!

mary-poppins commented Mar 19, 2018

Uh oh!

ngbot Bot commented Mar 20, 2018

Uh oh!

ngbot Bot commented Mar 20, 2018

Uh oh!

ngbot Bot commented Mar 20, 2018

Uh oh!

mary-poppins commented Mar 21, 2018

Uh oh!

alexeagle commented Mar 21, 2018

Uh oh!

mary-poppins commented Mar 28, 2018

Uh oh!

googlebot commented Mar 29, 2018

Uh oh!

mary-poppins commented Mar 29, 2018

Uh oh!

mary-poppins commented Mar 29, 2018

Uh oh!

mary-poppins commented Mar 29, 2018

Uh oh!

mary-poppins commented Mar 29, 2018

Uh oh!

ngbot Bot commented Mar 30, 2018

Uh oh!

mary-poppins commented Apr 13, 2018

Uh oh!

mary-poppins commented Apr 13, 2018

Uh oh!

gkalpak Mar 30, 2018

Choose a reason for hiding this comment

Uh oh!

alexeagle Apr 13, 2018

Choose a reason for hiding this comment

Uh oh!

googlebot commented Apr 13, 2018

Uh oh!

mary-poppins commented Apr 13, 2018

Uh oh!

IgorMinar Apr 13, 2018

Choose a reason for hiding this comment

Uh oh!

alexeagle Apr 13, 2018

Choose a reason for hiding this comment

Uh oh!

IgorMinar Apr 13, 2018

Choose a reason for hiding this comment

Uh oh!

alexeagle Apr 13, 2018

Choose a reason for hiding this comment

Uh oh!

angular-automatic-lock-bot Bot commented Sep 13, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants