-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Update seq tests from 3.14.4 #7606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1969,7 +1969,6 @@ def check_set_op_does_not_crash(self, function): | |
| self.assertIn("changed size during iteration", str(e)) | ||
|
|
||
|
|
||
| @unittest.skip("TODO: RUSTPYTHON; segfault") | ||
| class TestBinaryOpsMutating(TestOperationsMutating): | ||
|
|
||
| def test_eq_with_mutation(self): | ||
|
|
@@ -2058,7 +2057,6 @@ class TestBinaryOpsMutating_Subclass_Set(TestBinaryOpsMutating, unittest.TestCas | |
| constructor2 = set | ||
|
|
||
|
|
||
| @unittest.skip("TODO: RUSTPYTHON; segfault") | ||
| class TestMethodsMutating(TestOperationsMutating): | ||
|
Comment on lines
-2061
to
2060
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This class no longer segfaults, right?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. correct:)
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Due to this, 66 tests will be reported as no longer being skipped. 🎉 |
||
|
|
||
| def test_issubset_with_mutation(self): | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This class no longer segfaults, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
correct:)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Due to this, 60 tests will be reported as no longer being skipped. 🎉