Skip to content

Update seq tests from 3.14.4 #7606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 3 commits into from
Apr 15, 2026
+210 −11
Merged

Update seq tests from 3.14.4 #7606

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
26e78cf
Remove skips
ShaharNaveh Apr 14, 2026
3188aa7
Update seq related tests
ShaharNaveh Apr 14, 2026
d90c46c
Mark failing test
ShaharNaveh Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Remove skips
  • Loading branch information
@ShaharNaveh
ShaharNaveh committed Apr 14, 2026
commit 26e78cf0b475183d85abfa48303ada6e41f3f8b5
2 changes: 0 additions & 2 deletions Lib/test/test_set.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1969,7 +1969,6 @@ def check_set_op_does_not_crash(self, function):
self.assertIn("changed size during iteration", str(e))


@unittest.skip("TODO: RUSTPYTHON; segfault")
class TestBinaryOpsMutating(TestOperationsMutating):
Copy link
Copy Markdown
Contributor

@fanninpm fanninpm Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This class no longer segfaults, right?

Copy link
Copy Markdown
Contributor Author

@ShaharNaveh ShaharNaveh Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correct:)

Copy link
Copy Markdown
Contributor

@fanninpm fanninpm Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to this, 60 tests will be reported as no longer being skipped. 🎉


def test_eq_with_mutation(self):
Expand Down Expand Up @@ -2058,7 +2057,6 @@ class TestBinaryOpsMutating_Subclass_Set(TestBinaryOpsMutating, unittest.TestCas
constructor2 = set


@unittest.skip("TODO: RUSTPYTHON; segfault")
class TestMethodsMutating(TestOperationsMutating):
Comment on lines -2061 to 2060
Copy link
Copy Markdown
Contributor

@fanninpm fanninpm Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This class no longer segfaults, right?

Copy link
Copy Markdown
Contributor Author

@ShaharNaveh ShaharNaveh Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correct:)

Copy link
Copy Markdown
Contributor

@fanninpm fanninpm Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to this, 66 tests will be reported as no longer being skipped. 🎉


def test_issubset_with_mutation(self):
Expand Down