Skip to content

Update seq tests from 3.14.4#7606

Merged
youknowone merged 3 commits intoRustPython:mainfrom
ShaharNaveh:update-seq-tests
Apr 15, 2026
Merged

Update seq tests from 3.14.4#7606
youknowone merged 3 commits intoRustPython:mainfrom
ShaharNaveh:update-seq-tests

Conversation

@ShaharNaveh
Copy link
Copy Markdown
Contributor

@ShaharNaveh ShaharNaveh commented Apr 14, 2026

No description provided.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 14, 2026 •
edited
Loading

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (5)
  • Lib/test/seq_tests.py is excluded by !Lib/**
  • Lib/test/test_dict.py is excluded by !Lib/**
  • Lib/test/test_listcomps.py is excluded by !Lib/**
  • Lib/test/test_set.py is excluded by !Lib/**
  • Lib/test/test_userdict.py is excluded by !Lib/**

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: ee5538b9-e256-4441-91d5-d17f9fd0a0b6

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ShaharNaveh ShaharNaveh changed the title Update seq tests Update seq tests from 3.14.4 Apr 14, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 14, 2026 •
edited
Loading

📦 Library Dependencies

The following Lib/ modules were modified. Here are their dependencies:

(module 'dict test_listcomps test_set test_userdict' not found)

Legend:

  • [+] path exists in CPython
  • [x] up-to-date, [ ] outdated

fanninpm
fanninpm reviewed Apr 14, 2026
View reviewed changes
Lib/test/test_set.py


@unittest.skip("TODO: RUSTPYTHON; segfault")
class TestBinaryOpsMutating(TestOperationsMutating):
Copy link
Copy Markdown
Contributor

@fanninpm fanninpm Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This class no longer segfaults, right?

Copy link
Copy Markdown
Contributor Author

@ShaharNaveh ShaharNaveh Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correct:)

Copy link
Copy Markdown
Contributor

@fanninpm fanninpm Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to this, 60 tests will be reported as no longer being skipped. 🎉

fanninpm
fanninpm reviewed Apr 14, 2026
View reviewed changes
Lib/test/test_set.py
Comment on lines -2061 to 2060
@unittest.skip("TODO: RUSTPYTHON; segfault")
class TestMethodsMutating(TestOperationsMutating):
Copy link
Copy Markdown
Contributor

@fanninpm fanninpm Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This class no longer segfaults, right?

Copy link
Copy Markdown
Contributor Author

@ShaharNaveh ShaharNaveh Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correct:)

Copy link
Copy Markdown
Contributor

@fanninpm fanninpm Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to this, 66 tests will be reported as no longer being skipped. 🎉

@fanninpm fanninpm mentioned this pull request Apr 14, 2026
Open
@youknowone youknowone merged commit c98939a into RustPython:main Apr 15, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fanninpm fanninpm fanninpm left review comments

@youknowone youknowone youknowone approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ShaharNaveh @youknowone @fanninpm