Install wxPython and make the ELF executable - #152
Conversation
|
Please, always provide a motivation for the PR! An explanatory comment, to make it easier to review (understand) the changes. I'll do this once again on your behalf, if you don't mind. |
|
Done, above. |
|
References:
|
| - run: python -m pip install pyinstaller | ||
| - env: | ||
| URL: https://extras.wxpython.org/wxPython4/extras/linux/gtk3/ubuntu-18.04 | ||
| run: python -m pip install --find-links ${URL} wxPython |
| URL: https://extras.wxpython.org/wxPython4/extras/linux/gtk3/ubuntu-18.04 | ||
| run: python -m pip install --find-links ${URL} wxPython | ||
| - run: python setup.py clean bundle | ||
| - run: chmod +x /home/runner/work/PythonTurtle/PythonTurtle/dist/PythonTurtle |
There was a problem hiding this comment.
I took a look at the documentation. The permissions will be lost in any case. The only solution is to tar up the file instead.
All in all, I'm not happy with the zipp'ed binary. It should be possible to download the binary directly. Also, the Upload-Artifact is probably the wrong Action. There should be a Create-Release action that does what we need, instead. Do you want to give that a shot?
|
I'm happy you continue on this road to get the implementation into a final state. Note that this can (should!) only be an intermediate solution. It's because where people would look for downloads is always the repository's Releases section. We need to publish new version there, in the long run. I was afraid I had pointed you into the current direction from the beginning. But looking at our past conversations I see that I suggested using the |
Co-authored-by: Peter Bittner <django@bittner.it>
Yes. I agree but I have taken a couple of shots at using |
|
Have you tried the code sample in their README? It should be pretty much copy+paste. Not even configuring a secret seems to be needed: on:
push:
tags:
- "*"
jobs:
deploy:
runs-on: ubuntu-latest
steps:
- name: Create Release
id: create_release
uses: actions/create-release@v1
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
tag_name: ${{ github.ref }}
release_name: PythonTurtle-v${{ github.ref }}(I omitted the It's possible that the artifacts that you create with your implementation come in handy here. "Something" needs to be provided for the release to be created. That needs to be figured out. P.S.: Interestingly, they don't seem to eat their own dog food... 😏 Would be good if we could find a similar project repository that uses that Action. For a working example. |
|
It appears that creating the build artifacts and releasing are (meant to be) separate activities. If that is true, the release workflow may look like this:
Now, how do we access the artifacts of the |
|
One workflow |
|
Good point! I hope that doesn't tightly couple the two workflows. (Imagine you have to directly create a release, but you wanted to - manually - try out the binaries first. That would be possible with independent workflows.) For the assets, it seems like one must first create a release and then upload assets using the |
|
Issue actions/create-release#79 seems to describe a setup that comes close to what we probably need. Or similar here, actions/create-release#14 (comment). |

This pull request pip installs wxPython before pyinstaller creates the Linux ELF file.
It also sets the execution permission on the ELF file so that it can be run.