Skip to content

Consolidate build workflows into a single one - #156

Merged
cool-RR merged 8 commits into
masterfrom
feature/consolidate-build-workflows
Dec 22, 2020
Merged

Consolidate build workflows into a single one#156
cool-RR merged 8 commits into
masterfrom
feature/consolidate-build-workflows

Conversation

@bittner

@bittner bittner commented Dec 22, 2020

Copy link
Copy Markdown
Member
  • More concise is better to keep things aligned.
  • Separate lines for list items in YAML are better for readability of changes.

@bittner bittner added the automation Technical processes that should be automated away, including packaging and releases label Dec 22, 2020
@bittner
bittner requested a review from cool-RR December 22, 2020 02:46
@bittner

bittner commented Dec 22, 2020

Copy link
Copy Markdown
Member Author

@cool-RR Can you please approve this PR, so we can merge it?

The Linux ELF binary works (you can download the artifacts from Actions > Build binaries > latest build). A macOS app and a Windows EXE are also created. You may want to verify whether the latter runs on your system.

Credits

This PR builds on research, troubleshooting and engineering by @cclauss (see #152, #153, #155). Thank you! 🥇
Sorry to see you closing your own PRs. 😞

Next steps

After merging this PR, we should look into replacing the Upload-Artifact action by the Create-Release action, so we get the actual GitHub releases in this repository. For related reading see #152 (comment) and #152 (comment).

@bittner
bittner force-pushed the feature/consolidate-build-workflows branch from 517cbfb to 7cdb64b Compare December 22, 2020 03:06
@bittner
bittner force-pushed the feature/consolidate-build-workflows branch from 7cdb64b to 55976fc Compare December 22, 2020 03:06
@cool-RR
cool-RR merged commit a51b770 into master Dec 22, 2020
@cool-RR
cool-RR deleted the feature/consolidate-build-workflows branch December 22, 2020 05:59
Comment thread .github/workflows/build.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automation Technical processes that should be automated away, including packaging and releases

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants