Install wxPython and make the ELF executable #152
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -13,8 +13,13 @@ jobs: | |
| - uses: actions/setup-python@v2 | ||
| - run: sudo apt-get install libsdl2-2.0-0 | ||
| - run: python -m pip install pyinstaller | ||
| - env: | ||
| URL: https://extras.wxpython.org/wxPython4/extras/linux/gtk3/ubuntu-18.04 | ||
| run: python -m pip install --find-links ${URL} wxPython | ||
| - run: python setup.py clean bundle | ||
| - run: chmod +x /home/runner/work/PythonTurtle/PythonTurtle/dist/PythonTurtle | ||
|
Member
There was a problem hiding this comment. I took a look at the documentation. The permissions will be lost in any case. The only solution is to tar up the file instead. All in all, I'm not happy with the zipp'ed binary. It should be possible to download the binary directly. Also, the Upload-Artifact is probably the wrong Action. There should be a Create-Release action that does what we need, instead. Do you want to give that a shot? |
||
| - run: tar -cfvz PythonTurtle_for_Linux.tgz /home/runner/work/PythonTurtle/PythonTurtle/dist/PythonTurtle | ||
| - uses: actions/upload-artifact@v2 | ||
| with: | ||
| name: PythonTurtle for Linux | ||
| path: PythonTurtle_for_Linux.tar | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely solved, congrats!