[WIP] Adding comment, Reason and RestartDelay parameter for Stop/Restart-Computer cmdlet by kvprasoon · Pull Request #17479 · PowerShell/PowerShell

kvprasoon · 2022-06-04T06:35:41Z

PR Summary

PR Context

This PR helps as it adds parameters which helps PowerShell users use Stop-Computer and Restart-Computer more like shutdown.exe.

PR Checklist

ghost · 2022-06-11T14:01:17Z

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

iSazonov · 2022-06-11T17:06:32Z

+        /// Specify a delay before the reboot occurs.
+        /// </summary>
+        [Parameter(ParameterSetName = DefaultParameterSet)]
+        [ValidateRange(0, UInt32.MaxValue)]


Suggested change

[ValidateRange(0, UInt32.MaxValue)]

[ValidateRange(ValidateRangeKind.Positive)]

iSazonov · 2022-06-11T17:11:00Z

+            flags[1] = Comment;
+            flags[2] = ShutdownReasons.Planned;
+
+            switch (Reason.ToString())


Why can't we assign flags[2] = Reason?

iSazonov · 2022-06-11T17:15:04Z

+        /// Provide a comment for rebooting the computer.
+        /// </summary>
+        [Parameter(ParameterSetName = DefaultParameterSet)]
+        public string Comment { get; set; } = string.Empty;


Why do we assign empty string? Can the parameter be null? If no we should add validation attribute.

https://github.com/PowerShell/PowerShell/pull/8112/files#r228037418

It accepts null, will change to nullOrEmpty.

iSazonov · 2022-06-11T17:22:06Z

+        /// <summary>
+        /// System related shutdown/restart.
+        /// </summary>        
+        System = 0x80050000,


I have doubts that we should allow all these values. Perhaps the best options is the ones offered by WIndows GUI.

was referring to previous discussions in the old PR
#8112 (comment)

Thought its an agreement to go ahead with the entire list.

pull-request-quantifier-deprecated · 2023-05-06T17:11:52Z

This PR has 320 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details

Label      : Large
Size       : +305 -15
Percentile : 72%

Total files changed: 3

Change summary by file extension:
.cs : +281 -15
.ps1 : +24 -0

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

Fast and predictable releases to production:
- Optimal size changes are more likely to be reviewed faster with fewer
  iterations.
- Similarity in low PR complexity drives similar review times.
Review quality is likely higher as complexity is lower:
- Bugs are more likely to be detected.
- Code inconsistencies are more likely to be detected.
Knowledge sharing is improved within the participants:
- Small portions can be assimilated better.
Better engineering practices are exercised:
- Solving big problems by dividing them in well contained, smaller problems.
- Exercising separation of concerns within the code changes.

What can I do to optimize my changes

Use the PullRequestQuantifier to quantify your PR accurately
- Create a context profile for your repo using the context generator
- Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
- Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
- Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
Change your engineering behaviors
- For PRs that fall outside of the desired spectrum, review the details and check if:
  - Your PR could be split in smaller, self-contained PRs instead
  - Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

One line was added: +1 -0
One line was deleted: +0 -1
One line was modified: +1 -1 (git diff doesn't know about modified, it will
interpret that line like one addition plus one deletion)
Change percentiles: Change characteristics (addition, deletion, modification)
of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

)

PowerShell#26315) Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: TravisEz13 <10873629+TravisEz13@users.noreply.github.com>

…owerShell#26322) Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: TravisEz13 <10873629+TravisEz13@users.noreply.github.com>

…PowerShell#26268) Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: TravisEz13 <10873629+TravisEz13@users.noreply.github.com> Co-authored-by: Travis Plunk <travis.plunk@microsoft.com>

…26281)

Co-authored-by: Dongbo Wang <dongbow@microsoft.com> Co-authored-by: Travis Plunk <travis.plunk@microsoft.com>

…owerShell#26326) Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: TravisEz13 <10873629+TravisEz13@users.noreply.github.com> Co-authored-by: Travis Plunk <travis.plunk@microsoft.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…26347)

The following experimental features are made stable: - PSNativeWindowsTildeExpansion - PSRedirectToVariable - PSSubsystemPluginModel

…owerShell#26355) Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…#26343)

… existing actions to use reusable get-changed-files action (PowerShell#26350) Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: TravisEz13 <10873629+TravisEz13@users.noreply.github.com> Co-authored-by: Travis Plunk <travis.plunk@microsoft.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Travis Plunk (HE/HIM) <tplunk@ntdev.microsoft.com>

…PowerShell#26365) Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: TravisEz13 <10873629+TravisEz13@users.noreply.github.com>

Co-authored-by: Aditya Patwardhan <adityap@microsoft.com>

…ts (PowerShell#25124)

…#27608) Co-authored-by: PowerShell Team Bot <69177312+pwshBot@users.noreply.github.com> Co-authored-by: Travis Plunk <travis.plunk@microsoft.com> Co-authored-by: Patrick Meinecke <SeeminglyScience@users.noreply.github.com>

Co-authored-by: Justin Chung <chungjustin@microsoft.com>

)

kilasuit · 2026-06-23T04:19:03Z

@kvprasoon are you still interested in finishing off this PR?

Co-authored-by: Justin Chung <124807742+jshigetomi@users.noreply.github.com>

Co-authored-by: Ilya <darpa@yandex.ru>

kvprasoon · 2026-06-23T18:09:41Z

Hey @kilasuit - I would like to. This was pending review from very long time. I will try to rebase and update the PR this week.

Copilot

Pull request overview

This PR extends the Windows implementations of Stop-Computer and Restart-Computer to support -Comment, -Reason, and delay parameters (to align more closely with shutdown.exe behavior), and updates the WSMan CIM invocation to call Win32ShutdownTracker with the additional arguments.

Changes:

Add ShutdownReasons enum plus new cmdlet parameters (Comment, Reason, and delay) to Stop-Computer / Restart-Computer.
Switch WSMan shutdown invocation from Win32Shutdown to Win32ShutdownTracker and pass Timeout, Comment, and ReasonCode.
Add Pester tests intended to validate parameter availability for Stop-Computer / Restart-Computer.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 13 comments.

File	Description
test/powershell/Modules/Microsoft.PowerShell.Management/Stop-Computer.Tests.ps1	Adds tests for new `-Comment` and `-Reason` parameters.
test/powershell/Modules/Microsoft.PowerShell.Management/Restart-Computer.Tests.ps1	Adds tests for new `-Comment` and `-Reason` parameters.
src/Microsoft.PowerShell.Commands.Management/commands/management/Computer.cs	Adds new parameters/enums and updates WSMan shutdown invocation to use `Win32ShutdownTracker`.

+            $ReasonList =  "Application", "Hardware", "OperatingSystem", "Other", "Power", "Software", "System", `
+            "BlueScreen", "Disk", "Environment", "Driver", "HotFix", "HotFixUninstall", "Unresponsive", "Installation", `
+                "Maintenance", "MMC", "NetworkConnectivity", "NetworkCard", "Other", "OtherDriver", "PowerSupply", "Processor", "Reconfigure", `
+                "SecurityIssue", "SecurityPatch","SecurityPatchUninstallation", "ServicePack", "ServicePackUninstallation", "TerminalServices", `
+                "Unstable", "Upgrade", "WMI"


+        It "Should support Reason types" {
+            $ReasonList =  "Application", "Hardware", "OperatingSystem", "Other", "Power", "Software", "System", `
+                "BlueScreen", "Disk", "Environment", "Driver", "HotFix", "HotFixUninstall", "Unresponsive", "Installation", `
+                "Maintenance", "MMC", "NetworkConnectivity", "NetworkCard", "Other", "OtherDriver", "PowerSupply", "Processor", "Reconfigure", `
+                "SecurityIssue", "SecurityPatch","SecurityPatchUninstallation", "ServicePack", "ServicePackUninstallation", "TerminalServices", `
+                "Unstable", "Upgrade", "WMI"


                                // If successful and the Restart parameter is specified, restart the computer
-                                object[] flags = new object[] { 6, 0 };
-                                ComputerWMIHelper.InvokeWin32ShutdownUsingWsman(
+                                object[] flags = new object[] { 0, 0, 0, 6 };
+                                ComputerWMIHelper.InvokeWin32ShutdownTrackerUsingWsman(
                                    this,


+        [Parameter]
+        [ValidateRange(ValidateRangeKind.Positive)]
+        public UInt32 ShutdownDelay { get; set; }


+        /// <summary>
+        /// Specify a delay before the reboot occurs.
+        /// </summary>


+        /// <summary>
+        /// Application related shutdown/restart.
+        /// </summary>
+        Application = 0x00040000,
+
+        /// <summary>
+        /// Hardware related shutdown/restart.
+        /// </summary>
+        Hardware = 0x80010000,


+        It "Should support -Comment parameter" {
+            Set-TesthookResult -testhookName $restartTesthookResultName -value $defaultResultValue
+            $comment = "Testing comment"
+            Stop-Computer -Comment $comment -ErrorAction Stop | Should -BeNullOrEmpty
+        }


+        It "Should support Reason types" {
+            $ReasonList =  "Application", "Hardware", "OperatingSystem", "Other", "Power", "Software", "System", `
+            "BlueScreen", "Disk", "Environment", "Driver", "HotFix", "HotFixUninstall", "Unresponsive", "Installation", `
+                "Maintenance", "MMC", "NetworkConnectivity", "NetworkCard", "Other", "OtherDriver", "PowerSupply", "Processor", "Reconfigure", `
+                "SecurityIssue", "SecurityPatch","SecurityPatchUninstallation", "ServicePack", "ServicePackUninstallation", "TerminalServices", `
+                "Unstable", "Upgrade", "WMI"
+            foreach ( $reason in $ReasonList ) {
+                Stop-Computer Reason $reason | Should -BeNullOrEmpty
+            }
+        }


+        It "Should support -Comment parameter" {
+            Set-TesthookResult -testhookName $restartTesthookResultName -value $defaultResultValue
+            $comment = "Testing comment"
+            Restart-Computer -Comment $comment -ErrorAction Stop | Should -BeNullOrEmpty
+        }


+        It "Should support Reason types" {
+            $ReasonList =  "Application", "Hardware", "OperatingSystem", "Other", "Power", "Software", "System", `
+                "BlueScreen", "Disk", "Environment", "Driver", "HotFix", "HotFixUninstall", "Unresponsive", "Installation", `
+                "Maintenance", "MMC", "NetworkConnectivity", "NetworkCard", "Other", "OtherDriver", "PowerSupply", "Processor", "Reconfigure", `
+                "SecurityIssue", "SecurityPatch","SecurityPatchUninstallation", "ServicePack", "ServicePackUninstallation", "TerminalServices", `
+                "Unstable", "Upgrade", "WMI"
+            foreach ( $reason in $ReasonList ) {
+                Restart-Computer -Reason $reason | Should -BeNullOrEmpty
+            }
+        }


…rShell#26185) Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Justin Chung <124807742+jshigetomi@users.noreply.github.com>

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: Justin Chung <124807742+jshigetomi@users.noreply.github.com>

… publish flow (PowerShell#27635)

…owerShell#27611) Co-authored-by: Justin Chung <chungjustin@microsoft.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

…#27663)

…ipeline (PowerShell#27667) 1. Create the `LocProject.json` file for PowerShell localization. 2. Remove the unused `.resx` resource files and source files. 3. Update the `ResourceValidation` tests.

Co-authored-by: Ilya <darpa@yandex.ru>

…shell into stopmessage-4857

kvprasoon requested review from adityapatwardhan and daxian-dbw as code owners June 4, 2022 06:35

pull-request-quantifier-deprecated Bot added the Large label Jun 4, 2022

ghost assigned adityapatwardhan Jun 4, 2022

kvprasoon changed the title ~~Addin comment, Reason and RestartDelay parameter for Staop/REstart-Computer cmdlet~~ [WIP] Adding comment, Reason and RestartDelay parameter for Stop/Restart-Computer cmdlet Jun 4, 2022

ghost added the Review - Needed The PR is being reviewed label Jun 11, 2022

iSazonov reviewed Jun 11, 2022

View reviewed changes

kvprasoon requested a review from iSazonov May 6, 2023 17:12

xtqqczze and others added 20 commits October 26, 2025 15:55

Enable CA1200: Avoid using cref tags with a prefix (PowerShell#26298)

00efbe6

Enable analyzers: Use char overload (PowerShell#26301)

fde5305

Bump actions/upload-artifact from 4 to 5 (PowerShell#26309)

0e1019f

Bump github/codeql-action from 4.30.9 to 4.31.0 (PowerShell#26308)

ba02868

Avoid regex for exact word matching in DscClassCache (PowerShell#26306

be195a4

)

Fix linux_packaging job being skipped when only packaging files change (

d13cdad

PowerShell#26315) Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: TravisEz13 <10873629+TravisEz13@users.noreply.github.com>

Refactor analyze job to reusable workflow and enable on Windows CI (P…

5e5e177

…owerShell#26322) Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: TravisEz13 <10873629+TravisEz13@users.noreply.github.com>

Replace fpm with dpkg-deb for DEB package generation (PowerShell#…

7e1ef1f

…26281)

Update SDK to 10.0.100-rc.2.25502.107 (PowerShell#26305)

df8fe25

Co-authored-by: Dongbo Wang <dongbow@microsoft.com> Co-authored-by: Travis Plunk <travis.plunk@microsoft.com>

Bump actions/upload-artifact from 4 to 5 (PowerShell#26328)

bf3d978

Bump actions/setup-dotnet from 4 to 5 (PowerShell#26327)

0d7c24f

Update the Microsoft.PowerShell.Native package version (PowerShell#…

d38d6fa

…26347)

Make some experimental features stable (PowerShell#26348)

943257b

The following experimental features are made stable: - PSNativeWindowsTildeExpansion - PSRedirectToVariable - PSSubsystemPluginModel

Add reusable get-changed-files action and refactor existing actions (P…

a936884

…owerShell#26355) Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Make the experimental feature PSFeedbackProvider stable (PowerShell…

eda7e4a

…#26343)

Bump github/codeql-action from 4.31.0 to 4.31.2 (PowerShell#26359)

c123223

Fix merge conflict checker for empty file lists and filter *.cs files (…

8851ab8

…PowerShell#26365) Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: TravisEz13 <10873629+TravisEz13@users.noreply.github.com>

pwshBot and others added 5 commits June 10, 2026 15:02

[master] Update branch for release (PowerShell#27582)

6ae5efc

Co-authored-by: Aditya Patwardhan <adityap@microsoft.com>

Remove -Daily from install-powershell.ps1 since it no longer exis…

dc4e8fe

…ts (PowerShell#25124)

Update metadata.json for servicing releases (PowerShell#27609)

13161f2

Co-authored-by: Justin Chung <chungjustin@microsoft.com>

Update CI workflow to also target servicing-* branches (PowerShell#27612

c136a20

)

behradbhrmi and others added 2 commits June 23, 2026 11:11

Add links to changelogs for versions 7.5 and 7.6 (PowerShell#27080)

f7bef31

Co-authored-by: Justin Chung <124807742+jshigetomi@users.noreply.github.com>

Apply suggestion from @iSazonov

87fe789

Co-authored-by: Ilya <darpa@yandex.ru>

kvprasoon requested a review from a team as a code owner June 23, 2026 18:09

Copilot AI review requested due to automatic review settings June 23, 2026 18:09

Copilot started reviewing on behalf of kvprasoon June 23, 2026 18:10 View session

Copilot AI reviewed Jun 23, 2026

View reviewed changes

yotsuda and others added 12 commits June 26, 2026 11:15

Fix progress bar rendering with double-width unicode characters (Powe…

7d596de

…rShell#26185) Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Justin Chung <124807742+jshigetomi@users.noreply.github.com>

Change New-Guid to generate UUID v7 by default (PowerShell#27033)

6f7ffc2

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: Justin Chung <124807742+jshigetomi@users.noreply.github.com>

PMC: Download deb_arm artifact to ensure package is available for PMC…

13d66be

… publish flow (PowerShell#27635)

Produce min-size package for arm64 architecture (PowerShell#27646)

0f53100

Avoid calling credential provider for public feed for Wix (PowerShell…

26757e2

…#27663)

[master] Update branch for release (PowerShell#27683)

0c22676

Prepare for onboarding PowerShell to the Native2Native localization p…

855d943

…ipeline (PowerShell#27667) 1. Create the `LocProject.json` file for PowerShell localization. 2. Remove the unused `.resx` resource files and source files. 3. Update the `ResourceValidation` tests.

Update metadata.json for July releases (PowerShell#27704)

6633089

added comment, reason and restartdelay parameters

5c6987e

Apply suggestion from @iSazonov

55f7781

Co-authored-by: Ilya <darpa@yandex.ru>

Merge branch 'stopmessage-4857' of https://github.com/kvprasoon/power…

31274f7

…shell into stopmessage-4857

kvprasoon requested review from SeeminglyScience, TravisEz13 and jshigetomi as code owners July 21, 2026 17:29

kvprasoon closed this Jul 21, 2026

kvprasoon mentioned this pull request Jul 23, 2026

Adding comment, Reason and RestartDelay parameter for Stop/Restart-Computer cmdlet #27721

Open

12 tasks

	[ValidateRange(0, UInt32.MaxValue)]
	[ValidateRange(ValidateRangeKind.Positive)]

Uh oh!

Conversation

kvprasoon commented Jun 4, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

PR Context

PR Checklist

Uh oh!

ghost commented Jun 11, 2022

Uh oh!

iSazonov Jun 11, 2022

Choose a reason for hiding this comment

Uh oh!

iSazonov Jun 11, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

iSazonov Jun 11, 2022

Choose a reason for hiding this comment

Uh oh!

kvprasoon Jun 12, 2022

Choose a reason for hiding this comment

Uh oh!

iSazonov Jun 11, 2022

Choose a reason for hiding this comment

Uh oh!

kvprasoon Jun 12, 2022

Choose a reason for hiding this comment

Uh oh!

pull-request-quantifier-deprecated Bot commented May 6, 2023

What can I do to optimize my changes

How to interpret the change counts in git diff output

Uh oh!

kilasuit commented Jun 23, 2026

Uh oh!

kvprasoon commented Jun 23, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

19 participants

kvprasoon commented Jun 4, 2022 •

edited

Loading