Skip to content

Avoid calling credential provider for public feed for Wix#27663

Merged
TravisEz13 merged 1 commit into
masterfrom
AvoidCredProviderForWix
Jul 7, 2026
Merged

Avoid calling credential provider for public feed for Wix#27663
TravisEz13 merged 1 commit into
masterfrom
AvoidCredProviderForWix

Conversation

@adityapatwardhan

Copy link
Copy Markdown
Member

PR Summary

This pull request makes a minor update to the Install-Wix function in wix.psm1 to further configure the dotnet-eng repository after registering it.

  • Repository configuration:
    • After registering the dotnet-eng repository, the script now sets its credential provider to None to ensure no credentials are required for access.

PR Context

PR Checklist

Copilot AI review requested due to automatic review settings July 7, 2026 21:08
@adityapatwardhan
adityapatwardhan requested review from a team and jshigetomi as code owners July 7, 2026 21:08
@adityapatwardhan adityapatwardhan added Backport-7.5.x-Consider Backport-7.6.x-Consider CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log labels Jul 7, 2026
@TravisEz13
TravisEz13 enabled auto-merge (squash) July 7, 2026 21:10

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request updates the WiX installation helper (Install-Wix) to further configure the dotnet-eng PSResourceGet repository so that the public Azure DevOps feed doesn’t trigger credential-provider behavior.

Changes:

  • After registering dotnet-eng, set the repository’s credential provider to None.
  • (Suggested) Improve robustness by handling environments where an older Microsoft.PowerShell.PSResourceGet is installed and may not support -CredentialProvider.

Comment thread tools/wix/wix.psm1
Comment on lines 45 to 47
$respository = Get-PSResourceRepository -Name 'dotnet-eng' -ErrorAction SilentlyContinue

if (-not $respository) {
Comment thread tools/wix/wix.psm1
if (-not $respository) {
Write-Verbose -Verbose "Registering dotnet-eng repository..."
Register-PSResourceRepository -Name 'dotnet-eng' -Uri 'https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-eng/nuget/v3/index.json' -Trusted
Set-PSResourceRepository -CredentialProvider None -Name 'dotnet-eng' -Trusted
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Backport-7.4.x-Migrated Backport-7.5.x-Migrated Backport-7.6.x-Migrated CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants