Prepare for onboarding PowerShell to the Native2Native localization pipeline#27667
Open
daxian-dbw wants to merge 2 commits into
Open
Prepare for onboarding PowerShell to the Native2Native localization pipeline#27667daxian-dbw wants to merge 2 commits into
daxian-dbw wants to merge 2 commits into
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Member
Author
|
/azp run |
|
Azure Pipelines: Successfully started running 3 pipeline(s). 2 pipeline(s) were filtered out due to trigger conditions. |
Member
Author
|
It will be tricky to backport the localized resources to old releases like 7.5 and 7.4. The localization will be based on resource strings in the master branch of GitHub repo. If we blindly backport all localized resources to 7.5 and 7.4, it's highly possible to break something, as some strings may be removed in later versions, but we are not backporting the corresponding code changes to 7.5 and 7.4. Given that 7.4 is about to reach the end of its life cycle, and 7.5 is not even the stable version today, I think we should not support localization for those 2 versions. For 7.6, the mismatch described above can also happen but should be in a smaller scale. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Native2Native localization pipeline: https://eng.ms/docs/cloud-ai-platform/azure-core/azure-experiences-and-ecosystems/cme-international-customer-exp/software-localization-onelocbuild/onelocbuild/native2native/overview
LocProject.jsonfile for PowerShell localization.resxresource files.cssource filesMicrosoft.PowerShell.LocalAccountsfolder as it's never built or shipped with PowerShell 7.The
LanguageSetused inLocProject.jsonfile for now is VS_Main_Languages, because that's what .NET runtime uses for its localization. I think we should target the same languages that .NET runtime targets. For a language that .NET doesn’t localize to, even if we localize PowerShell resources for it, it still won’t be fully localized given that any .NET exceptions will use the fallback en-US strings.Impact on package size: Localization will increase the size of PowerShell package because we need to ship the satellite assemblies. The language set
VS_Main_Languagesincludes 13 languages. If we use it, the size of PowerShell will increase around 10 mb (6 mb for S.M.A satellite assemblies along).To be decided: We need to decide the language set to use before filing the onboarding request.