feat: enable external signer mode for production - #2083
Merged
Conversation
remove the restriction that allowed the external signer to be used only in a test env Ticket: BG-43925
DariusParvin
force-pushed
the
BG-43925-remove-signer-prod-restriction
branch
from
March 8, 2022 00:28
5104574 to
077d2de
Compare
DariusParvin
marked this pull request as ready for review
March 8, 2022 00:28
Codecov Report
@@ Coverage Diff @@
## master #2083 +/- ##
===========================================
+ Coverage 0 52.50% +52.50%
===========================================
Files 0 6 +6
Lines 0 558 +558
Branches 0 85 +85
===========================================
+ Hits 0 293 +293
- Misses 0 259 +259
- Partials 0 6 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
tylerlevine
approved these changes
Mar 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
remove the restriction that allowed the external signer to be used only in a test env
Note: This should only be merged after the following PRs have been merged
Ticket: BG-43925