feat: add fetchEncryptedPrivKeys.ts - #2080
Merged
Merged
Conversation
DariusParvin
force-pushed
the
BG-43925-fetch-keys-for-external-signer
branch
from
March 7, 2022 18:06
168d1f2 to
60733aa
Compare
Codecov Report
@@ Coverage Diff @@
## master #2080 +/- ##
===========================================
+ Coverage 0 87.30% +87.30%
===========================================
Files 0 183 +183
Lines 0 9862 +9862
Branches 0 1419 +1419
===========================================
+ Hits 0 8610 +8610
- Misses 0 814 +814
- Partials 0 438 +438
Flags with carried forward coverage won't be shown. Click here to find out more.
|
DariusParvin
force-pushed
the
BG-43925-fetch-keys-for-external-signer
branch
3 times, most recently
from
March 7, 2022 20:14
20e83fe to
aad3ea6
Compare
tylerlevine
suggested changes
Mar 7, 2022
tylerlevine
left a comment
Contributor
There was a problem hiding this comment.
more good work here - just some suggestions for a little bit of a cleaner implementation and doc improvements.
This file will help create a json with the users wallet ids and encrypted private keys to be used by the external signer. Ticket: BG-43925
DariusParvin
force-pushed
the
BG-43925-fetch-keys-for-external-signer
branch
from
March 7, 2022 21:29
aad3ea6 to
136fbab
Compare
DariusParvin
commented
Mar 7, 2022
Contributor
Author
|
ready for re-review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This file will help create a json with the users wallet ids and encrypted
private keys to be used by the external signer.
I created this file based off the files in
modules/core/example.Ticket: BG-43925