feat: external signer to read encrypted privkeys - #2069
Merged
DariusParvin merged 3 commits intoMar 8, 2022
Conversation
DariusParvin
force-pushed
the
BG-43925-external-signer-encrypted-passphrase
branch
from
March 3, 2022 20:34
5023710 to
8ca00a3
Compare
Codecov Report
@@ Coverage Diff @@
## master #2069 +/- ##
===========================================
+ Coverage 0 53.01% +53.01%
===========================================
Files 0 6 +6
Lines 0 564 +564
Branches 0 86 +86
===========================================
+ Hits 0 299 +299
- Misses 0 259 +259
- Partials 0 6 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
DariusParvin
marked this pull request as ready for review
March 3, 2022 21:19
DariusParvin
force-pushed
the
BG-43925-external-signer-encrypted-passphrase
branch
from
March 7, 2022 17:30
6063a07 to
92ad3b0
Compare
added 2 commits
March 7, 2022 09:47
- When running in external signer mode, express will expect the private key json file to be in the encrypted format (same as on the keycard but with escape characters). - Express expects the wallet passphrase to be set in the environment with the name WALLET_<walletId>_PASSPHRASE Ticket: BG-43925
- private keys should be in encrypted format with escaped characters - wallet passphrase should be set as a environment var - add headers and move diagram up Ticket: BG-43925
DariusParvin
force-pushed
the
BG-43925-external-signer-encrypted-passphrase
branch
from
March 7, 2022 17:48
92ad3b0 to
a456f22
Compare
tylerlevine
suggested changes
Mar 7, 2022
tylerlevine
left a comment
Contributor
There was a problem hiding this comment.
good work, just a few comments
- create new doc EXTERNAL_SIGNER.md - add example configuration settings Ticket: BG-43925
DariusParvin
force-pushed
the
BG-43925-external-signer-encrypted-passphrase
branch
from
March 7, 2022 20:45
a456f22 to
2300f14
Compare
Contributor
Author
|
Good catches, thanks for the feedback. I've addressed them now |
This was referenced Mar 7, 2022
tylerlevine
approved these changes
Mar 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
key json file to be in the encrypted format (same as on the keycard but
with escape characters).
with the name
WALLET_<walletId>_PASSPHRASETicket: BG-43925