Repository navigation
Add error message and exit when there are no versionable packages - #1466
Merged
Andarist merged 4 commits intoOct 10, 2024
Merged
Conversation
🦋 Changeset detectedLatest commit: ee1ff40 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
marcalexiei
commented
Sep 21, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1466 +/- ##
==========================================
+ Coverage 81.02% 81.04% +0.02%
==========================================
Files 54 54
Lines 2213 2221 +8
Branches 654 661 +7
==========================================
+ Hits 1793 1800 +7
- Misses 416 417 +1
Partials 4 4 ☔ View full report in Codecov by Sentry. |
marcalexiei
force-pushed
the
feat/no-verionable-packages-info
branch
from
October 7, 2024 07:02
1c04a81 to
7e9886e
Compare
bluwy
reviewed
Oct 8, 2024
marcalexiei
force-pushed
the
feat/no-verionable-packages-info
branch
from
October 8, 2024 12:31
7e9886e to
7ff6f59
Compare
marcalexiei
commented
Oct 8, 2024
bluwy
approved these changes
Oct 8, 2024
bluwy
left a comment
Member
There was a problem hiding this comment.
I think the flow and fix here looks good. Not sure if others have thoughts on the error logged info.
Andarist
reviewed
Oct 9, 2024
Andarist
reviewed
Oct 9, 2024
Andarist
reviewed
Oct 9, 2024
| error("No versionable packages found"); | ||
| error('- Ensure the packages to version are not in the "ignore" config'); | ||
| error('- Ensure that relevant package.json files have the "version" field'); | ||
| throw new ExitError(1); |
Member
There was a problem hiding this comment.
note for myself: this is nicely handled here:
changesets/packages/cli/src/index.ts
Lines 105 to 107 in 7ccb22e
so 👍
Andarist
reviewed
Oct 9, 2024
Merged
Merged
1 of 5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #1170
fix #841
I have added an informative message in the scenario where no versionable packages are found.
This should cover also the error reported in the issue linked above (public packages without
versionfield in package).