Repository navigation
Lint: enable jest/max-nested-describe rule - #1501
marcalexiei wants to merge 3 commits into
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1501 +/- ##
=======================================
Coverage 81.04% 81.04%
=======================================
Files 54 54
Lines 2221 2221
Branches 657 661 +4
=======================================
Hits 1800 1800
Misses 417 417
Partials 4 4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
This file contains a large amount of tests so I created multiple describe blocks in the file root.
There was a problem hiding this comment.
I addition to edit tests title I used #region and #endregion vscode markers to keep related test together
This PR is a based on top of #1496 changes,
it aims to enable
jest/max-nested-describerule as per review of #1466 (comment).Note
I'm creating a separate PR to simplify review process since there a lot of code changes (mostly indentation 😅).
Caution
This is marked as draft because should be reviewed after #1496 is merged.
Tip
If there are too many changes I can disable the rule in biggest file (like
packages/cli/src/commands/version/version.test.ts) and restore their original content.