Repository navigation
add format script - #1495
add format script#1495
format script#1495Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1495 +/- ##
=======================================
Coverage 81.04% 81.04%
=======================================
Files 54 54
Lines 2221 2221
Branches 657 661 +4
=======================================
Hits 1800 1800
Misses 417 417
Partials 4 4 ☔ View full report in Codecov by Sentry. |
|
Does format on save still work in VS Code and uses Prettier config to do its job? |
Yes, of course! You just need to have prettier extension installed and select it as formatter Also, let me know what do you think about |
Yeah, this could be nice |
Close #1492
eslint-plugin-prettier,eslint-config-prettieris retained in the config to disable formatting ruleslint:prettierscript toformatprettierscript toformat:fixlinttask renamed tolint_and_format, I think that there is no need to create a new job for just runformatscripteslintcrcI removed thepackages/cli/default-files/config.jsoverride since the folder no longer contains any js fileI also noticed that
eslint-plugin-jestis not used, so I removed it from the dependencies.Since the project is using
jestI would consider to enable this plugin.For instance, it includes a max-nested-describe rule that could resolve the describe "issue" reported in this review comment.
If you agree, I'm willing to work on a PR to achieve this,
Ideally I'll start working on it after #1467 is merged (it already change some test related code).