Skip to content

feat(vortex-geo): add intersection scalar function - #9220

Open
HarukiMoriarty wants to merge 3 commits into
nemo/geo-convex-hullfrom
nemo/geo-intersection-native
Open

feat(vortex-geo): add intersection scalar function#9220
HarukiMoriarty wants to merge 3 commits into
nemo/geo-convex-hullfrom
nemo/geo-intersection-native

Conversation

@HarukiMoriarty

@HarukiMoriarty HarukiMoriarty commented Aug 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Stacked on #9219.

Summary

  • add native polygonal intersection overloads backed by geo::BooleanOps: Polygon × Polygon, Polygon × MultiPolygon, MultiPolygon × Polygon, and MultiPolygon × MultiPolygon
  • return a native 2D MultiPolygon for every overload
  • preserve constant/column execution and strict null propagation through the existing binary dispatcher
  • add Q9-oriented coverage for overlap, disjoint, boundary-touching, holes, constants, nulls, and all four input-type combinations
  • add focused rectangle and detailed-boundary microbenchmarks

NaN/invalid-coordinate checking remains outside the default execution path, consistent with the rest of the native geo scalar stack.

Checks

  • cargo +nightly fmt --all
  • cargo test -p vortex-geo (254 passed)
  • cargo clippy -p vortex-geo --all-targets --all-features -- -D warnings
  • cargo clippy --all-targets --all-features -- -D warnings
  • cargo bench -p vortex-geo --bench intersection
  • git diff --check

@codspeed-hq

codspeed-hq Bot commented Aug 5, 2026 •
edited
Loading

Copy link
Copy Markdown

Merging this PR will regress 3 benchmarks

⚡ 4 improved benchmarks
❌ 3 regressed benchmarks
✅ 1905 untouched benchmarks
🆕 9 new benchmarks
⏩ 43 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
❌ Simulation decompress[dict_fsst_varbin_string] 19.2 ms 21.5 ms -10.94%
❌ Simulation decompress[dict_fsst_varbin_bp_string] 19.2 ms 21.5 ms -10.92%
❌ Simulation chunked_dict_primitive_into_canonical[u32, (1000, 10, 100)] 1.6 ms 1.8 ms -10.74%
⚡ Simulation mul_u8_nonnull 405.6 µs 165.2 µs ×2.5
⚡ Simulation mul_u16_nonnull 501.9 µs 269.3 µs +86.4%
⚡ Simulation decompress[u64, (1000, 16)] 134.6 µs 72.4 µs +85.96%
⚡ Simulation mul_u32_nonnull 722.5 µs 486.5 µs +48.51%
🆕 Simulation chunked_varbin_into_canonical[(10, 100)] N/A 709.7 µs N/A
🆕 Simulation chunked_varbin_into_canonical[(500, 2)] N/A 176 µs N/A
🆕 Simulation chunked_varbin_opt_to_varbinview_builder[(10, 100)] N/A 836.8 µs N/A
🆕 Simulation chunked_varbin_opt_to_varbinview_builder[(500, 2)] N/A 164 µs N/A
🆕 Simulation chunked_varbin_to_varbinview_builder[(10, 100)] N/A 510.7 µs N/A
🆕 Simulation chunked_varbin_to_varbinview_builder[(500, 2)] N/A 165.1 µs N/A
🆕 Simulation nullable_rectangles N/A 12.5 ms N/A
🆕 Simulation rectangles N/A 13.3 ms N/A
🆕 Simulation thirty_two_vertex_boundaries N/A 52.7 ms N/A

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.

Comparing nemo/geo-intersection-native (f2b5e90) with nemo/geo-convex-hull (ba1e979)2

Open in CodSpeed

Footnotes

  1. 43 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. No successful run was found on nemo/geo-convex-hull (40c257d) during the generation of this report, so 7c66940 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@HarukiMoriarty HarukiMoriarty mentioned this pull request Aug 6, 2026
Open
@HarukiMoriarty
HarukiMoriarty force-pushed the nemo/geo-intersection-native branch from af47d2b to f2b5e90 Compare August 6, 2026 14:41
@HarukiMoriarty
HarukiMoriarty force-pushed the nemo/geo-intersection-native branch from f2b5e90 to 0da3ab6 Compare August 6, 2026 17:58
@HarukiMoriarty
HarukiMoriarty force-pushed the nemo/geo-intersection-native branch from 0da3ab6 to 17b600b Compare August 6, 2026 20:13
@HarukiMoriarty
feat(vortex-geo): add intersection scalar function
7876719 
Signed-off-by: Nemo Yu <zyu379@wisc.edu>
@HarukiMoriarty
bench(vortex-geo): add intersection benchmark
2d1ad21 
Signed-off-by: Nemo Yu <zyu379@wisc.edu>
@HarukiMoriarty
feat(vortex-geo): intersect multipolygons
fc74be9 
Signed-off-by: Nemo Yu <zyu379@wisc.edu>
@HarukiMoriarty
HarukiMoriarty force-pushed the nemo/geo-intersection-native branch from 17b600b to fc74be9 Compare August 6, 2026 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@HarukiMoriarty