Skip to content

feat(vortex-geo): add convex hull scalar function - #9219

Open
HarukiMoriarty wants to merge 3 commits into
nemo/geo-collectfrom
nemo/geo-convex-hull
Open

feat(vortex-geo): add convex hull scalar function#9219
HarukiMoriarty wants to merge 3 commits into
nemo/geo-collectfrom
nemo/geo-convex-hull

Conversation

@HarukiMoriarty

@HarukiMoriarty HarukiMoriarty commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add a strict native MultiPoint to Polygon convex-hull scalar function
  • delegate planar hull computation directly to geo::ConvexHull
  • preserve CRS and outer nullability while materializing native 2-D Polygon storage
  • use shared unary dispatch for constants and strict null propagation
  • cover empty, one-point, collinear, nullable, constant, and Q5-style collect-to-hull-to-area execution
  • add a dedicated convex-hull microbenchmark

Semantics

The return dtype is always native Polygon, including empty and degenerate hulls. Consistent with the current geometry-kernel policy, coordinate finiteness is unchecked unless validation is explicitly enabled; this function does not add per-call NaN validation.

@codspeed-hq

codspeed-hq Bot commented Aug 6, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 11.84%

❌ 1 regressed benchmark
✅ 711 untouched benchmarks
⏩ 1242 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation compress_fsst[(1000, 64, 8)] 1 ms 1.2 ms -11.84%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing nemo/geo-convex-hull (5c27ddf) with nemo/geo-collect (9428981)

Open in CodSpeed

Footnotes

  1. 1242 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Signed-off-by: Nemo Yu <zyu379@wisc.edu>
Signed-off-by: Nemo Yu <zyu379@wisc.edu>
Signed-off-by: Nemo Yu <zyu379@wisc.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/feature A new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant