Skip to content

Increse duckdb retries when operating on parquet s3#8903

Open
robert3005 wants to merge 1 commit into
developfrom
rk/retries
Open

Increse duckdb retries when operating on parquet s3#8903
robert3005 wants to merge 1 commit into
developfrom
rk/retries

Conversation

@robert3005

Copy link
Copy Markdown
Contributor

This roughly matches object_store behaviour

Signed-off-by: Robert Kruszewski <github@robertk.io>
@github-actions

github-actions Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Polar Signals Profiling Results

Latest Run

Status Commit Job Attempt Link
🟢 Done 7742136 1 Explore Profiling Data

Powered by Polar Signals Cloud

@github-actions

Copy link
Copy Markdown
Contributor

Benchmarks: Vortex queries 📖

Verdict: No clear signal (medium confidence)
Attributed Vortex impact: +9.5%
Engines: DataFusion Likely regression (+25.1%, high confidence) · DuckDB No clear signal (-4.1%, low confidence)
Vortex (geomean): 1.043x ➖
Parquet (geomean): 0.996x ➖
Shifts: Parquet (control) -0.4% · Median polish -0.4%

How to read Verdict and Engines
  • Verdict: Overall PR-level signal after subtracting baseline drift estimated from Parquet control rows. It can be Likely improvement, Likely regression, or No clear signal.
  • Engines: Per-engine attribution. DataFusion is compared against DataFusion/Parquet controls; DuckDB is compared against DuckDB/Parquet controls. This answers whether each engine improved or regressed independently.
  • Confidence: Based on directional consistency, share of rows above the noise floor, and control-run noise.

datafusion / vortex-file-compressed (1.239x ❌, 0↑ 2↓)
name PR 7742136 (ns) base 57962f4 (ns) ratio (PR/base)
vortex_q00/datafusion:vortex-file-compressed 🚨 9820577 8197567 1.20
vortex_q01/datafusion:vortex-file-compressed 🚨 6258092 4885078 1.28
datafusion / parquet (0.990x ➖, 0↑ 0↓)
name PR 7742136 (ns) base 57962f4 (ns) ratio (PR/base)
vortex_q00/datafusion:parquet 20186530 20638806 0.98
vortex_q01/datafusion:parquet 4589861 4580085 1.00
duckdb / vortex-file-compressed (0.961x ➖, 0↑ 0↓)
name PR 7742136 (ns) base 57962f4 (ns) ratio (PR/base)
vortex_q00/duckdb:vortex-file-compressed 10012170 10061599 1.00
vortex_q01/duckdb:vortex-file-compressed 5725904 6167184 0.93
duckdb / parquet (1.003x ➖, 0↑ 0↓)
name PR 7742136 (ns) base 57962f4 (ns) ratio (PR/base)
vortex_q00/duckdb:parquet 23331928 23195009 1.01
vortex_q01/duckdb:parquet 9335531 9340266 1.00

No file size changes detected.

@robert3005 robert3005 added the changelog/chore A trivial change label Jul 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/chore A trivial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant