Skip to content

Commit 7742136

Browse files
committed
Increse duckdb retries when operating on parquet s3
Signed-off-by: Robert Kruszewski <github@robertk.io>
1 parent 759562a commit 7742136

1 file changed

Lines changed: 12 additions & 1 deletion

File tree

benchmarks/duckdb-bench/src/main.rs

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,12 @@ use vortex_bench::runner::filter_queries;
2626
use vortex_bench::setup_logging_and_tracing;
2727
use vortex_bench::v3;
2828

29+
const S3_HTTP_INIT_SQL: [&str; 3] = [
30+
"SET http_retries = 8",
31+
"SET http_retry_wait_ms = 250",
32+
"SET http_retry_backoff = 2",
33+
];
34+
2935
/// Common arguments shared across benchmarks
3036
#[derive(Parser)]
3137
struct Args {
@@ -159,6 +165,11 @@ fn main() -> anyhow::Result<()> {
159165
)?;
160166

161167
let benchmark_name = benchmark.dataset().to_string();
168+
let mut duckdb_init_sql = Vec::new();
169+
if benchmark.data_url().scheme() == "s3" {
170+
duckdb_init_sql.extend(S3_HTTP_INIT_SQL.map(String::from));
171+
}
172+
duckdb_init_sql.extend(benchmark.engine_init_sql(Engine::DuckDB));
162173

163174
let mode = if args.explain {
164175
BenchmarkMode::Explain
@@ -178,7 +189,7 @@ fn main() -> anyhow::Result<()> {
178189
args.delete_duckdb_database,
179190
args.threads,
180191
)?;
181-
ctx.set_init_sql(benchmark.engine_init_sql(Engine::DuckDB))?;
192+
ctx.set_init_sql(duckdb_init_sql.clone())?;
182193
ctx.register_tables(&*benchmark, format)?;
183194

184195
// Duckdb doesn't support octet_length for strings but we need this

0 commit comments

Comments
 (0)