Skip to content

tests: fix lsfd/mkfds-multiplexing coproc PID handling #4404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
karelzak wants to merge 1 commit into
base: master
Choose a base branch
from
+11 −3
Draft

tests: fix lsfd/mkfds-multiplexing coproc PID handling #4404

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions tests/ts/lsfd/mkfds-multiplexing
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,13 +45,21 @@ for multiplexer in pselect6 select poll ppoll; do
{
coproc MKFDS { "$TS_HELPER_MKFDS" -w "$multiplexer" multiplexing {10..22}; }
} > "$TS_OUTPUT" 2>&1
# bash unsets MKFDS_PID when the coproc terminates; save it
MKFDS_CPID=$MKFDS_PID

if read -r -u "${MKFDS[0]}" PID; then
if ! kill -0 "$PID" 2>/dev/null; then
wait "$MKFDS_CPID"
ts_skip "the $multiplexer process exited unexpectedly"
ts_finalize_subtest
continue
fi
syscall_line=$(cat /proc/"${PID}"/syscall 2>> "$TS_OUTPUT")
syscall_status=$?
if [[ "$syscall_status" != 0 ]]; then
kill -CONT "${PID}"
wait "${MKFDS_PID}"
wait "$MKFDS_CPID"
ts_skip "cannot open /proc/${PID}/syscall"
ts_finalize_subtest
continue
Expand All @@ -61,7 +69,7 @@ for multiplexer in pselect6 select poll ppoll; do
# on any platforms.
if [[ "$syscall_n" == 0 ]]; then
kill -CONT "${PID}"
wait "${MKFDS_PID}"
wait "$MKFDS_CPID"
ts_skip "incorrect syscall number in /proc/${PID}/syscall"
ts_finalize_subtest
continue
Expand All @@ -80,7 +88,7 @@ for multiplexer in pselect6 select poll ppoll; do
} >> "$TS_OUTPUT" 2>&1
fi

wait "${MKFDS_PID}"
wait "$MKFDS_CPID"
ts_finalize_subtest
done

Expand Down
Loading