tests: fix lsfd/mkfds-multiplexing coproc PID handling#4404
Draft
karelzak wants to merge 1 commit into
Draft
Conversation
Bash automatically unsets the MKFDS_PID variable when the coproc terminates. If the multiplexer syscall is not available at runtime (e.g., select on ppc64le with kernel 6.18 returns ENOSYS despite __NR_select being defined at compile time), the coproc exits immediately and MKFDS_PID becomes empty, causing: wait: '': not a pid or valid job spec Save MKFDS_PID to a regular variable (MKFDS_CPID) immediately after starting the coproc. Additionally, add a kill -0 liveness check after reading the PID to detect when the multiplexer process died early (e.g., due to ENOSYS) and skip the subtest cleanly. Signed-off-by: Karel Zak <kzak@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bash automatically unsets the MKFDS_PID variable when the coproc terminates. If the multiplexer syscall is not available at runtime (e.g., select on ppc64le with kernel 6.18 returns ENOSYS despite __NR_select being defined at compile time), the coproc exits immediately and MKFDS_PID becomes empty, causing:
wait: '': not a pid or valid job spec
Save MKFDS_PID to a regular variable (MKFDS_CPID) immediately after starting the coproc.
Additionally, add a kill -0 liveness check after reading the PID to detect when the multiplexer process died early (e.g., due to ENOSYS) and skip the subtest cleanly.