Skip to content

asyncuniswap test fixture fix #490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
liquid-8 merged 3 commits into from
Oct 14, 2026
Merged

asyncuniswap test fixture fix #490

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c20ff3a
test: switch mainnet RPC in CI tests
liquid-8 Oct 11, 2026
36b834f
README update
liquid-8 Oct 14, 2026
a1057a0
async_uniswap fixture fix
liquid-8 Oct 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@ on:
env:
# The repo secret still points at a rate-limited Infura URL, so CI must use
# the public endpoint directly instead of preferring the secret on push runs.
PROVIDER_MAINNET: 'https://ethereum.publicnode.com'
#PROVIDER_MAINNET: 'https://ethereum.publicnode.com'
PROVIDER_MAINNET: 'https://eth.drpc.org'
PROVIDER_ARBITRUM: 'https://arb1.arbitrum.io/rpc'
PROVIDER_XDAI: 'https://rpc.ankr.com/gnosis'

Expand Down
6 changes: 6 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,12 @@ Contributors also earn this beautiful [GitPOAP](https://gitpoap.notion.site/What

## Changelog

_0.9.0_
* Added: Async versions of Uniswap V2-V4
* Added: V2 and V3 custom routes (untested)
* Added: Async pool cache service for Uniswap V4
* Removed: V1 support

@greptile-apps greptile-apps Bot Oct 14, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 V1 removal claim is incorrect

The changelog says V1 support was removed, but both Uniswap and AsyncUniswap still accept version=1 and load V1 contracts. The README also lists V1 as deprecated. Describe deprecation rather than removal so users do not plan unnecessary migrations.

Suggested change
* Removed: V1 support
* Deprecated: V1 support


_0.8.0_

* Added: Uniswap V4 support
Expand Down
3 changes: 1 addition & 2 deletions tests/test_asyncuniswap.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,7 @@ def tokens(client: AsyncUniswap):
return get_tokens(client.netname)


@pytest.fixture(scope="module")
@pytest.mark.asyncio
@pytest_asyncio.fixture(scope="module")
async def test_assets(client: AsyncUniswap):
"""
Buy some DAI and USDC to test with.
Expand Down
Loading