Skip to content

asyncuniswap test fixture fix - #490

Merged
liquid-8 merged 3 commits into
uniswap-python:dev/v4-finfrom
liquid-8:v4_UF_grant
Oct 14, 2026
Merged

liquid-8 merged 3 commits into
uniswap-python:dev/v4-finfrom
liquid-8:v4_UF_grant

Conversation

@liquid-8

Copy link
Copy Markdown
Member

No description provided.

@codecov

codecov Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.21%. Comparing base (4a45cf9) to head (a1057a0).
⚠️ Report is 16 commits behind head on dev/v4-fin.

Additional details and impacted files
@@              Coverage Diff               @@
##           dev/v4-fin     #490      +/-   ##
==============================================
- Coverage       70.48%   70.21%   -0.27%     
==============================================
  Files              14       14              
  Lines            4282     4284       +2     
==============================================
- Hits             3018     3008      -10     
- Misses           1264     1276      +12     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@greptile-apps

greptile-apps Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 4/5

[Medium impact] Updates test infrastructure and CI environment configuration.

The PR appears safe to merge, with a non-blocking correction needed in the changelog.

Findings

  1. P2 V1 removal claim is incorrect ▶

Summary

This PR fixes how pytest runs the async asset fixture.

  • Async trade tests can use their token setup fixture.
  • CI's mainnet test forks use the DRPC endpoint.
  • The README now lists the 0.9.0 release notes.

Reviews (1) · Last reviewed commit: "async_uniswap fixture fix" · Reviewed by Greptile

Comment thread README.md
* Added: Async versions of Uniswap V2-V4
* Added: V2 and V3 custom routes (untested)
* Added: Async pool cache service for Uniswap V4
* Removed: V1 support

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 V1 removal claim is incorrect

The changelog says V1 support was removed, but both Uniswap and AsyncUniswap still accept version=1 and load V1 contracts. The README also lists V1 as deprecated. Describe deprecation rather than removal so users do not plan unnecessary migrations.

Suggested change
* Removed: V1 support
* Deprecated: V1 support

@liquid-8
liquid-8 merged commit aad7a59 into uniswap-python:dev/v4-fin Oct 14, 2026
12 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant