fix(webapp): record real payload size on the trigger span#4166
Conversation
batchTrigger and batchTriggerAndWait (and the by-id and by-task variants) now offload any per-item payload over 128KB to object storage before sending, the same way single trigger and triggerAndWait already do, so a big batch no longer blows past the API body limit. Every trigger and batch item also reports its pre-offload serialised payload size on the request options, so a consumer can tell how big a payload is without fetching the offloaded application/store reference.
When a payload is offloaded to object storage the trigger span only saw the small application/store reference, so its size attribute measured the reference, not the payload. Prefer the caller-reported pre-offload size when present so the span reflects the real payload size. Inline payloads are unchanged.
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
3ff70ab to
9f64bfb
Compare
Summary
When a payload is offloaded to object storage the trigger span only saw the small
application/storereference, so itssizeattribute measured the reference rather than the payload. It now prefers the caller-reported pre-offload size (options.payloadSize) when present, so the span reflects the real payload size. Inline payloads are unchanged.Stacked on #4165, which adds the
payloadSizeoption this reads.This is part 2 of 2 in a stack made with GitButler: