Skip to content

fix(webapp): record real payload size on the trigger span#4166

Draft
1stvamp wants to merge 1 commit into
feature/large-batch-payloadsfrom
feature/payload-size-span
Draft

fix(webapp): record real payload size on the trigger span#4166
1stvamp wants to merge 1 commit into
feature/large-batch-payloadsfrom
feature/payload-size-span

Conversation

@1stvamp

@1stvamp 1stvamp commented Jul 6, 2026

Copy link
Copy Markdown
Member

Summary

When a payload is offloaded to object storage the trigger span only saw the small application/store reference, so its size attribute measured the reference rather than the payload. It now prefers the caller-reported pre-offload size (options.payloadSize) when present, so the span reflects the real payload size. Inline payloads are unchanged.

Stacked on #4165, which adds the payloadSize option this reads.


This is part 2 of 2 in a stack made with GitButler:

When a payload is offloaded to object storage the trigger span only saw the small application/store reference, so its size attribute measured the reference, not the payload. Prefer the caller-reported pre-offload size when present so the span reflects the real payload size. Inline payloads are unchanged.
@changeset-bot

changeset-bot Bot commented Jul 6, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 2817a54

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: b7c1154b-b248-42bb-88ed-dec422d2a9a9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/payload-size-span

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant