Skip to content

Bug fix: difficult_words_list#193

Closed
dogweather wants to merge 5 commits into
textstat:masterfrom
dogweather:bug-fixes
Closed

Bug fix: difficult_words_list#193
dogweather wants to merge 5 commits into
textstat:masterfrom
dogweather:bug-fixes

Conversation

@dogweather
Copy link
Copy Markdown

@dogweather dogweather commented Jul 20, 2022

Fixes #192

@alxwrd
Copy link
Copy Markdown
Member

alxwrd commented Aug 6, 2022

Hey! This is currently based off of your dogweather/master branch, which contains changes for #190. We can either rebase this onto textstat/master, or wait until dogweather/master is merged.

@dogweather
Copy link
Copy Markdown
Author

dogweather commented Aug 7, 2022

Hey! This is currently based off of your dogweather/master branch, which contains changes for #190. We can either rebase this onto textstat/master, or wait until dogweather/master is merged.

Thanks!

BTW, I found more errors and so I bought a copy of Dale & Chall's book and did a deep dive, implementing the formula from scratch: https://github.com/public-law/new-dale-chall-readability. I used sample scored texts from the book as integration tests.

I discovered a lot of differences in the answers I got from textstat vs. my implementation. Maybe textstat should be conceived as an umbrella project and use this library for the Dale-Chall calculations.

@alxwrd
Copy link
Copy Markdown
Member

alxwrd commented Oct 26, 2022

Closing as stale

@alxwrd alxwrd closed this Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Logic bug in difficult_words_list()

2 participants