Support type-checkers and other tools#190
Closed
dogweather wants to merge 3 commits into
Closed
Conversation
Author
|
@LKirst What do you think about the idea of this PR? I realize it's not exactly what the architecture describes. Instead I wanted to make the smallest change possible and keep the existing API. |
This was referenced Jul 20, 2022
alxwrd
requested changes
Aug 6, 2022
Member
alxwrd
left a comment
There was a problem hiding this comment.
Hi @dogweather! Thank you for this. Sorry for the delay in a review.
I don't think the extra analyzer is required. The __init__.py of Textstat already imports the default instance as textstat which should be compatible with the language server.
Happy to add an import for TextStatistics in __init__.py though:
from .textstat import textstat, Textstatistics
__version__ = (0, 7, 2)
...
Member
|
Closing as stale |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I found that I needed to make a couple small changes to allow Pyright and the Language Server to work seamlessly with the library. The lib already has type hints, but I found that it needed a couple small PEP-8 fixes to fully type-check. With these changes, I also get code completion and some python docstring support. I use VS Code and Pylance/Pyright in strict mode:
I made minimal changes which preserve the existing API.
Fixes: #191