Skip to content

fixes #122 #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tillahoffmann merged 2 commits into from
Dec 8, 2020
Merged

fixes #122 #123

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6579608
fixes #122
shikhar08 Dec 7, 2020
d3e0651
fixes #122
shikhar08 Dec 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions testcontainers/selenium.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,7 @@ class BrowserWebDriverContainer(DockerContainer):
"""
def __init__(self, capabilities, image=None):
self.capabilities = capabilities
if not image:
self.image = get_image_name(capabilities)
self.image = image or get_image_name(capabilities)
self.port_to_expose = 4444
self.vnc_port_to_expose = 5900
super(BrowserWebDriverContainer, self).__init__(image=self.image)
Expand Down
9 changes: 9 additions & 0 deletions tests/test_selenium.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@

def test_selenium_custom_image():
from testcontainers.selenium import BrowserWebDriverContainer
from selenium.webdriver import DesiredCapabilities

image = "selenium/standalone-chrome:latest"
chrome = BrowserWebDriverContainer(DesiredCapabilities.CHROME, image=image)
assert "image" in dir(chrome), "`image` attribute was not instantialized."
assert chrome.image == image, "`image` attribute was not set to the user provided value"