fixes #122#123
Merged
tillahoffmann merged 2 commits intoDec 8, 2020
Merged
Conversation
tillahoffmann
approved these changes
Dec 7, 2020
Contributor
tillahoffmann
left a comment
There was a problem hiding this comment.
Nice, will merge once tests pass.
Codecov Report
@@ Coverage Diff @@
## master #123 +/- ##
==========================================
- Coverage 83.36% 83.33% -0.04%
==========================================
Files 22 22
Lines 529 528 -1
Branches 36 35 -1
==========================================
- Hits 441 440 -1
- Misses 70 71 +1
+ Partials 18 17 -1
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@tillahoffmann
As discussed in the issue #122 , here's my fix.
I've also added a test.