Merged
Conversation
a939d47 to
642a9be
Compare
dcd7e6e to
1c2d757
Compare
642a9be to
f0de912
Compare
1c2d757 to
0d660a3
Compare
f0de912 to
ebe8125
Compare
0d660a3 to
4fe7a14
Compare
ebe8125 to
cfa12c9
Compare
4fe7a14 to
e2c6dee
Compare
cfa12c9 to
359ed00
Compare
86b4541 to
738154a
Compare
359ed00 to
c24502e
Compare
738154a to
e8b6282
Compare
c24502e to
754a2f8
Compare
e8b6282 to
edab501
Compare
c01ebe1 to
740cbfa
Compare
edab501 to
190179a
Compare
740cbfa to
d937b57
Compare
190179a to
b462ad9
Compare
d937b57 to
d1652c8
Compare
468728e to
b343d23
Compare
b343d23 to
c9348e4
Compare
d1652c8 to
6340dbe
Compare
c9348e4 to
4acd666
Compare
6ab4d8b to
c5c3594
Compare
8a20cf5 to
217dc60
Compare
c5c3594 to
75fd551
Compare
217dc60 to
65af36b
Compare
5ab0cc8 to
de96668
Compare
The @config-editing tests need the gateway booted from the config-in-database read path (TENSORZERO_INTERNAL_FLAG_ENABLE_CONFIG_IN_DATABASE=true) with a pre-loaded config — they cannot run in the standard ui-tests-e2e-main job. Additionally, the tests make direct API calls to $TENSORZERO_GATEWAY_URL from the Playwright runner (host process), but the main e2e job sets that variable to http://gateway:3000 which is only resolvable within the Docker network, causing EAI_AGAIN failures. Changes: - Tag all tests in config_editing.spec.ts with @config-editing so they can be selected or excluded via --grep / --grep-invert. - Add @config-editing to the --grep-invert filter in ui-tests-e2e-main for all three auth_mode matrix legs. - Add ui/fixtures/docker-compose.config-in-db.yml: a Docker Compose override that adds a gateway-store-config one-shot service (stores the UI fixtures config into Postgres) and rewires the gateway to load from the database. - Add ui-tests-e2e-config-editing CI job: starts the stack with the config-in-db override, then runs playwright with --grep @config-editing and TENSORZERO_GATEWAY_URL=http://localhost:3000 so the host-side runner can reach the gateway via the mapped port.
de96668 to
4d3a06b
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: de9666807e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Aaron1011
reviewed
Apr 13, 2026
4ef7e23 to
6d392d4
Compare
Aaron1011
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a config editor in UI to edit config toml. This only triggers when gateway reports the config is in database (currently gated behind the feature flag, and requires the gateway to start up without a config file passed in).
Normal view:

Edit conflict:

Invalid toml:

Fixes #7176.