Skip to content

a comment added to explain the use of HashMap #347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stleary merged 2 commits into from
Jun 12, 2017
Merged

a comment added to explain the use of HashMap #347

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d0f5607
a comment added to explain the use of HashMap
ttulka Jun 8, 2017
246350b
comment added to explain the reason that JSON object is unordered
ttulka Jun 9, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions JSONObject.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,12 @@ public String toString() {
* Construct an empty JSONObject.
*/
public JSONObject() {
// HashMap is used on purpose to ensure that elements are unordered by
// the specification.
// JSON tends to be a portable transfer format to allows the container
// implementations to rearrange their items for a faster element
// retrieval based on associative access.
// Therefore, an implementation mustn't rely on the order of the item.
this.map = new HashMap<String, Object>();
}

Expand Down Expand Up @@ -216,15 +222,15 @@ public JSONObject(JSONTokener x) throws JSONException {
key = x.nextValue().toString();
}

// The key is followed by ':'.
// The key is followed by ':'.

c = x.nextClean();
if (c != ':') {
throw x.syntaxError("Expected a ':' after a key");
}
this.putOnce(key, x.nextValue());

// Pairs are separated by ','.
// Pairs are separated by ','.

switch (x.nextClean()) {
case ';':
Expand Down