a comment added to explain the use of HashMap#347
Conversation
to avoid misconception of contributors about using HashMap to implement a JSON object as a unordered collection by the definition
|
Since we are going to document this in the code, let's include a thorough explanation, e.g. what design goal is met by using an unordered container and why an ordered container is specifically not used. You can use the text from the Wiki, although I think your own interpretation could be better. This is a good example of how not all code is inherently self-documenting. |
to avoid implementators' misconceptions and tries to reimplement the JSON object to keep the elements order
|
I tried my best. There is actually not a lot of information about this issue and I see several misconceptions in the discussion forums. So, the explanation is very welcome, I guess :-) |
|
What problem does this code solve? Risks Changes to the API? Will this require a new release? Should the documentation be updated? Does it break the unit tests? Was any code refactored in this commit? Review status |
to avoid misconception of contributors about using HashMap to implement a JSON object as a unordered collection by the definition