feat: add C implementation for stats/base/dists/negative-binomial/logpmf - #14740
Closed
Planeshifter wants to merge 1 commit into
Closed
feat: add C implementation for stats/base/dists/negative-binomial/logpmf#14740Planeshifter wants to merge 1 commit into
stats/base/dists/negative-binomial/logpmf#14740Planeshifter wants to merge 1 commit into
Conversation
…gpmf` PR-URL: #10132 Co-authored-by: nirmaljb <nirmaljb@users.noreply.github.com> Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Member
Author
|
Closing in favor of the updated #10132 — the fixes were pushed directly to the contributor's branch. |
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #3762.
Description
This pull request:
@stdlib/stats/base/dists/negative-binomial/logpmfstats/base/dists/negative-binomial/logpmf#10132, rebased on latest develop and rewritten to usekernel-betaincinstead of inliningibetaPowerTermsRelated Issues
This pull request has the following related issues:
@stdlib/stats/base/dists/negative-binomial/logpmf#3762stats/base/dists/negative-binomial/logpmf#10132Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was written primarily by Claude Code, building on the contributor work in #10132 by @nirmaljb. The C implementation was rewritten to call
kernel_betaincfor the derivative instead of inlining the BoostibetaPowerTermshelper. All tests, benchmarks, and examples were built and run locally.@stdlib-js/reviewers