Skip to content

feat: add C implementation for stats/base/dists/negative-binomial/logpmf - #10132

Merged
Planeshifter merged 2 commits into
stdlib-js:developfrom
nirmaljb:feat/negative-binomial/logpmf
Aug 28, 2026
Merged

feat: add C implementation for stats/base/dists/negative-binomial/logpmf#10132
Planeshifter merged 2 commits into
stdlib-js:developfrom
nirmaljb:feat/negative-binomial/logpmf

Conversation

@nirmaljb

@nirmaljb nirmaljb commented Feb 7, 2026

Copy link
Copy Markdown
Contributor

type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes. report:

  • task: lint_filenames status: passed
  • task: lint_editorconfig status: passed
  • task: lint_markdown status: passed
  • task: lint_package_json status: passed
  • task: lint_repl_help status: na
  • task: lint_javascript_src status: passed
  • task: lint_javascript_cli status: na
  • task: lint_javascript_examples status: na
  • task: lint_javascript_tests status: passed
  • task: lint_javascript_benchmarks status: passed
  • task: lint_python status: na
  • task: lint_r status: na
  • task: lint_c_src status: missing_dependencies
  • task: lint_c_examples status: missing_dependencies
  • task: lint_c_benchmarks status: missing_dependencies
  • task: lint_c_tests_fixtures status: na
  • task: lint_shell status: na
  • task: lint_typescript_declarations status: passed
  • task: lint_typescript_tests status: na
  • task: lint_license_headers status: passed ---

Resolves #3762.

Description

What is the purpose of this pull request?

This pull request:

  • Adds a C implementation of the negative binomial logpmf.
  • Includes benchmarks for the C implementation.
  • Provides examples demonstrating the usage of the negative binomial logpmf in C.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Good First PR A pull request resolving a Good First Issue. Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Feb 7, 2026
@stdlib-bot

stdlib-bot commented Feb 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/negative-binomial/logpmf $\\color{red}619/662$
$\\color{green}+0.00\\%$ 		$\\color{red}47/53$
$\\color{green}+0.00\\%$ 		$\\color{green}6/6$
$\\color{green}+0.00\\%$ 		$\\color{red}619/662$
$\\color{green}+0.00\\%$

The above coverage report was generated for the changes in this PR.

@nirmaljb nirmaljb mentioned this pull request Feb 10, 2026
Closed
Planeshifter
Planeshifter requested changes Apr 20, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/stats/base/dists/negative-binomial/logpmf/src/main.c Outdated
Comment thread lib/node_modules/@stdlib/stats/base/dists/negative-binomial/logpmf/src/addon.c Outdated
Comment thread lib/node_modules/@stdlib/stats/base/dists/negative-binomial/logpmf/lib/native.js
Comment thread lib/node_modules/@stdlib/stats/base/dists/negative-binomial/logpmf/manifest.json
Comment thread lib/node_modules/@stdlib/stats/base/dists/negative-binomial/logpmf/benchmark/c/benchmark.c Outdated
Comment thread lib/node_modules/@stdlib/stats/base/dists/negative-binomial/logpmf/src/main.c Outdated
Comment thread lib/node_modules/@stdlib/stats/base/dists/negative-binomial/logpmf/src/main.c Outdated
@Planeshifter Planeshifter added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Apr 20, 2026
@Planeshifter Planeshifter mentioned this pull request Jun 11, 2026
Merged
7 tasks
@Neerajpathak07
Neerajpathak07 requested a review from a team August 3, 2026 11:09
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Aug 3, 2026
@Neerajpathak07
Neerajpathak07 force-pushed the feat/negative-binomial/logpmf branch from c0db21f to 5b2347d Compare August 3, 2026 11:13
This was referenced Aug 26, 2026
Open
Closed
@Planeshifter
Planeshifter force-pushed the feat/negative-binomial/logpmf branch from c25cb82 to f40c20c Compare August 28, 2026 05:20
Planeshifter added a commit to nirmaljb/stdlib that referenced this pull request Aug 28, 2026
@Planeshifter @nirmaljb @claude
feat: add C implementation for `stats/base/dists/negative-binomial/lo…
f40c20c 
…gpmf`

PR-URL: stdlib-js#10132

Co-authored-by: nirmaljb <nirmaljb@users.noreply.github.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@Planeshifter Planeshifter added the METR Pull request associated with the METR project. label Aug 28, 2026
@Planeshifter @nirmaljb @claude
feat: add C implementation for `stats/base/dists/negative-binomial/lo…
35fa937 
…gpmf`

PR-URL: stdlib-js#10132

Co-authored-by: nirmaljb <nirmaljb@users.noreply.github.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@Planeshifter
Planeshifter force-pushed the feat/negative-binomial/logpmf branch from f40c20c to 35fa937 Compare August 28, 2026 06:20
Planeshifter
Planeshifter reviewed Aug 28, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/stats/base/dists/negative-binomial/logpmf/README.md Outdated
@Planeshifter
chore: revert copyright year change
f185fd3 
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
@Planeshifter
Planeshifter merged commit ff9f24a into stdlib-js:develop Aug 28, 2026
13 checks passed
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Aug 28, 2026
@Planeshifter Planeshifter mentioned this pull request Aug 29, 2026
Draft
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

Assignees

No one assigned

Labels

Good First PR A pull request resolving a Good First Issue. METR Pull request associated with the METR project. Needs Changes Pull request which needs changes before being merged. Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[RFC]: Add C implementation for @stdlib/stats/base/dists/negative-binomial/logpmf

3 participants

@nirmaljb @stdlib-bot @Planeshifter