chore: use format for error messages in datasets/* build scripts#12157
Draft
Planeshifter wants to merge 1 commit into
Draft
chore: use format for error messages in datasets/* build scripts#12157Planeshifter wants to merge 1 commit into
format for error messages in datasets/* build scripts#12157Planeshifter wants to merge 1 commit into
Conversation
Propagates the fix from 0205e0a ("chore: fix JavaScript lint errors") to sibling dataset build scripts that construct error messages via string concatenation. Replaces concatenation with `@stdlib/string/format` to satisfy the `stdlib/no-error-string-concat` ESLint rule.
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Propagating fixes merged to
developbetween 2026-05-15 and 2026-05-16 to sibling packages.formatfor error-message construction (stdlib/no-error-string-concat)Commit
0205e0ada("chore: fix JavaScript lint errors", #12138) replaced string concatenation in athrow new Errormessage with@stdlib/string/formatto resolve thestdlib/no-error-string-concatESLint rule. Seven sibling dataset build scripts carry the identical violation. This pull request applies the same conversion at each site: it imports@stdlib/string/formatand rewrites the error messages with%d/%splaceholders.Source:
0205e0adaTarget packages:
datasets/cdc-nchs-us-births-1969-1988datasets/cdc-nchs-us-births-1994-2003datasets/fivethirtyeight-ffqdatasets/frb-sf-wage-rigiditydatasets/berndt-cps-wages-1985datasets/emoji-code-pictodatasets/moby-dick(four occurrences)Related Issues
This pull request does not have any related issues.
Questions
No.
Other
Validation
Search scope: all
scripts/*.jsbuild scripts underlib/node_modules/@stdlib/datasets/*, scanned forthrow new Errormessages constructed via string concatenation.stdlib/no-error-string-concatviolation and that placeholder types are correct (%dfor integer array lengths and loop indices,%sfor string values).cdc-nchs-us-births-*scripts are byte-identical to the source's pre-fix line and take the fix verbatim.requireplacement andformatcall formatting match each package and the source commit.datasets/cdc-nchs-us-infant-mortality-bw-1915-2013already imports@stdlib/string/formatand was excluded.No sites required cross-package changes, new tests, or interpretation, and none were flagged for human review.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This pull request was prepared by Claude Code running an automated routine that propagates recently merged fixes to sibling packages. The routine identified the source commit, located the affected sibling scripts, validated each site with independent review passes, and applied the patches.
@stdlib-js/reviewers
Generated by Claude Code