Skip to content

chore: fix JavaScript lint errors#12138

Merged
kgryte merged 2 commits into
stdlib-js:developfrom
popsiclelmlm:chore/fix-ssa-births-lint
May 15, 2026
Merged

chore: fix JavaScript lint errors#12138
kgryte merged 2 commits into
stdlib-js:developfrom
popsiclelmlm:chore/fix-ssa-births-lint

Conversation

@popsiclelmlm
Copy link
Copy Markdown
Contributor

@popsiclelmlm popsiclelmlm commented May 15, 2026

Summary

  • replace string concatenation in the SSA births dataset build script error message with @stdlib/string/format

Related Issues

Verification

  • node --check lib/node_modules/@stdlib/datasets/ssa-us-births-2000-2014/scripts/build.js

  • git diff --check

  • Read, understood, and followed the contributing guidelines

@popsiclelmlm popsiclelmlm requested a review from a team May 15, 2026 01:39
@stdlib-bot stdlib-bot added the First-time Contributor A pull request from a contributor who has never previously committed to the project repository. label May 15, 2026
@stdlib-bot
Copy link
Copy Markdown
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

@stdlib-bot stdlib-bot added Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels May 15, 2026
@stdlib-bot
Copy link
Copy Markdown
Contributor

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

Getting Started

Next Steps

  1. A project maintainer will approve GitHub Actions workflows for your PR.
  2. All CI checks must pass before your submission can be fully reviewed.
  3. You'll need to address any failures in linting or unit tests.

Running Tests Locally

You can use make to run any of the CI commands locally from the root directory of the stdlib repository:

# Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"

# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*"

If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR.

If you have any further questions while waiting for a response, please join our Zulip community to chat with project maintainers and other community members.

We appreciate your contribution!

Documentation Links

@kgryte kgryte added difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. review: 5 and removed Needs Review A pull request which needs code review. labels May 15, 2026
Comment thread lib/node_modules/@stdlib/datasets/ssa-us-births-2000-2014/scripts/build.js Outdated
Co-authored-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
@stdlib-bot
Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
datasets/ssa-us-births-2000-2014 $\color{green}146/146$
$\color{green}+100.00%$
$\color{green}7/7$
$\color{green}+100.00%$
$\color{green}2/2$
$\color{green}+100.00%$
$\color{green}146/146$
$\color{green}+100.00%$

The above coverage report was generated for the changes in this PR.

@kgryte kgryte changed the title chore: fix JavaScript lint errors (issue #12137) chore: fix JavaScript lint errors May 15, 2026
@kgryte kgryte merged commit 0205e0a into stdlib-js:develop May 15, 2026
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue. review: 3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix JavaScript lint errors

3 participants